Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for Nested Services in Policy Service #836

Merged
merged 10 commits into from
Mar 1, 2023
Merged

Adding support for Nested Services in Policy Service #836

merged 10 commits into from
Mar 1, 2023

Conversation

AxFrancois
Copy link
Contributor

@AxFrancois AxFrancois commented Feb 13, 2023

Hi!

As requested in Issue #700 and #831, my contribution is adding support for nested service.

Fixes: #700
Fixes: #831

@vmwclabot
Copy link
Member

@AxFrancois, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot vmwclabot added the dco-required DCO Required label Feb 13, 2023
@vmwclabot
Copy link
Member

@AxFrancois, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot
Copy link
Member

@AxFrancois, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot vmwclabot removed the dco-required DCO Required label Feb 13, 2023
@AxFrancois
Copy link
Contributor Author

I didn't create tests, let me know if I have to.

Signed-off-by: Axel Francois <[email protected]>
@annakhm
Copy link
Collaborator

annakhm commented Feb 18, 2023

Hello @AxFrancois, thank you for this contribution! I've left a couple of minor comments. Yes, we normally add tests for all new features.

@annakhm
Copy link
Collaborator

annakhm commented Feb 18, 2023

Please ignore the failed checks for now - fix for this (upgrading golang version) will be merged soon.

Axel Francois added 5 commits February 20, 2023 08:46
Signed-off-by: Axel Francois <[email protected]>
Signed-off-by: Axel Francois <[email protected]>
Signed-off-by: Axel Francois <[email protected]>
Signed-off-by: Axel Francois <[email protected]>
Signed-off-by: Axel Francois <[email protected]>
@AxFrancois
Copy link
Contributor Author

Hi @annakhm , I made the requested changes. Let me know if there is something else to do.

@AxFrancois
Copy link
Contributor Author

Is this failed check linked to the fact that I used go 1.20 ?

@annakhm
Copy link
Collaborator

annakhm commented Feb 24, 2023

Hi @AxFrancois, thank you for addressing comments. I've left one more small request for the sake of tests on global manager. Also rebasing this PR would solve the website-lint issue. Thanks!

@vmwclabot
Copy link
Member

@AxFrancois, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot vmwclabot added the dco-required DCO Required label Feb 27, 2023
Signed-off-by: Axel Francois <[email protected]>
@vmwclabot vmwclabot removed the dco-required DCO Required label Feb 27, 2023
@vmwclabot
Copy link
Member

@AxFrancois, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot vmwclabot added the dco-required DCO Required label Feb 27, 2023
@vmwclabot
Copy link
Member

@AxFrancois, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot
Copy link
Member

@AxFrancois, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot vmwclabot removed the dco-required DCO Required label Feb 27, 2023
@AxFrancois
Copy link
Contributor Author

Sorry for making this bot working overtime because of the dco...

@annakhm
Copy link
Collaborator

annakhm commented Feb 28, 2023

/test-all

Signed-off-by: Axel Francois <[email protected]>
@annakhm
Copy link
Collaborator

annakhm commented Mar 1, 2023

Thank you for this contribution @AxFrancois, merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants