-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for Nested Services in Policy Service #836
Conversation
@AxFrancois, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
@AxFrancois, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
@AxFrancois, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
Signed-off-by: Axel Francois <[email protected]>
I didn't create tests, let me know if I have to. |
Signed-off-by: Axel Francois <[email protected]>
Hello @AxFrancois, thank you for this contribution! I've left a couple of minor comments. Yes, we normally add tests for all new features. |
Please ignore the failed checks for now - fix for this (upgrading golang version) will be merged soon. |
Signed-off-by: Axel Francois <[email protected]>
Signed-off-by: Axel Francois <[email protected]>
Signed-off-by: Axel Francois <[email protected]>
Signed-off-by: Axel Francois <[email protected]>
Signed-off-by: Axel Francois <[email protected]>
Hi @annakhm , I made the requested changes. Let me know if there is something else to do. |
Is this failed check linked to the fact that I used go 1.20 ? |
Hi @AxFrancois, thank you for addressing comments. I've left one more small request for the sake of tests on global manager. Also rebasing this PR would solve the |
@AxFrancois, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
Signed-off-by: Axel Francois <[email protected]>
@AxFrancois, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
@AxFrancois, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
@AxFrancois, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
Signed-off-by: Axel Francois <[email protected]>
Sorry for making this bot working overtime because of the dco... |
/test-all |
Signed-off-by: Axel Francois <[email protected]>
Thank you for this contribution @AxFrancois, merging |
Hi!
As requested in Issue #700 and #831, my contribution is adding support for nested service.
Fixes: #700
Fixes: #831