Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README to reflect provider release #2

Merged
merged 2 commits into from
Apr 14, 2018
Merged

Update README to reflect provider release #2

merged 2 commits into from
Apr 14, 2018

Conversation

vancluever
Copy link
Contributor

Now that the provider has been released, there are a number of items in
the old README that are no longer relevant. This commit replaces the
README with one that has been template from the vSphere provider, and
should better reflect what one would need to do to use the provider or
develop it, including up to date installation and development
instructions, and a referral to the Terraform website for documentation.

CC @avoltmer. Fixes #1.

Now that the provider has been released, there are a number of items in
the old README that are no longer relevant. This commit replaces the
README with one that has been template from the vSphere provider, and
should better reflect what one would need to do to use the provider or
develop it, including up to date installation and development
instructions, and a referral to the Terraform website for documentation.
@avoltmer
Copy link
Contributor

avoltmer commented Apr 9, 2018

I don't believe I have the right permissions to accept this pull request or do writes.

@vancluever
Copy link
Contributor Author

vancluever commented Apr 9, 2018

@avoltmer Just looking for a LGTM (aka "Looks Good To Me", or a "verbal" approval in other words) in this message. I can do the merge.

Thanks!

@avoltmer
Copy link
Contributor

@vancluever - There are a few things from the old README.md that we thought should stay there but are not in your update. Here are two options:

  1. Merge your pull and then I can do a second update once you give me write access.
  2. Discard and I can try to do the whole update with your changes and what I want to keep.

@vancluever
Copy link
Contributor Author

@avoltmer we can just close this one. I'll keep an eye out for the PR with the updated README.

Thanks!

@vancluever vancluever closed this Apr 10, 2018
@vancluever vancluever deleted the b-fix-readme branch April 10, 2018 01:14
@avoltmer avoltmer restored the b-fix-readme branch April 14, 2018 00:59
@avoltmer avoltmer reopened this Apr 14, 2018
@avoltmer avoltmer merged commit 8c2fe7f into master Apr 14, 2018
@avoltmer avoltmer deleted the b-fix-readme branch April 14, 2018 01:17
@avoltmer
Copy link
Contributor

Reopened the pull request and did some updates for missing items in the README.md and merged it to master and closed the pull request.

annakhm pushed a commit that referenced this pull request Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants