Add validators to transport node resource

[annakhm]

When user provides empty strings or empty lists, NSX fails the request without specifying what exactly is missing. It is preferrable to fail those invalid configs on plan stage.

[annakhm]

/test-all

[GraysonWu]

When user provides empty strings or empty lists, NSX fails the request without specifying what exactly is missing. It is preferrable to fail those invalid configs on plan stage.

I'm wondering if the same issue also exists in other resources.

[ksamoray]

LGTM

[salv-orlando]

LGTM

[salv-orlando]

When user provides empty strings or empty lists, NSX fails the request without specifying what exactly is missing. It is preferrable to fail those invalid configs on plan stage.

I'm wondering if the same issue also exists in other resources.

While I agree it might be best to fail in plan stage and I also think the issue will exist in other resources, we should also not forget that we don't want to do validation in place of NSX API, as this will create logic duplication and possibly create a bit of complexity in Interop.

It's fine though to pre-validate those field which should not be empty, as that's not something that should be expected to change in NSX API evolution. Regardless I would not scan all existing resources for these case, maybe let's just consider doing this in auto-generated code.

[annakhm]

When user provides empty strings or empty lists, NSX fails the request without specifying what exactly is missing. It is preferrable to fail those invalid configs on plan stage.

I'm wondering if the same issue also exists in other resources.

I'm reluctant to apply this validator to released resources, since this can break backwards compatibility. But we can go over resources in Beta and improve validation there.