Add validators to transport node resource

When user provides empty strings or empty lists, NSX fails the request without specifying what exactly is missing. It is preferrable to fail those invalid configs on plan stage. Signed-off-by: Anna Khmelnitsky <[email protected]>
vmware · Feb 12, 2024 · 52c7b50 · 52c7b50
1 parent 8c0081c
commit 52c7b50
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 6 deletions.
diff --git a/nsxt/resource_nsxt_edge_transport_node.go b/nsxt/resource_nsxt_edge_transport_node.go
@@ -558,9 +558,10 @@ func getTransportZoneEndpointSchema() *schema.Schema {
 		Elem: &schema.Resource{
 			Schema: map[string]*schema.Schema{
 				"transport_zone": {
-					Type:        schema.TypeString,
-					Required:    true,
-					Description: "Unique ID identifying the transport zone for this endpoint",
+					Type:         schema.TypeString,
+					Required:     true,
+					Description:  "Unique ID identifying the transport zone for this endpoint",
+					ValidateFunc: validation.StringIsNotWhiteSpace,
 				},
 				"transport_zone_profiles": {
 					Type:        schema.TypeList,
@@ -584,9 +585,10 @@ func getUplinksSchema() *schema.Schema {
 		Elem: &schema.Resource{
 			Schema: map[string]*schema.Schema{
 				"uplink_name": {
-					Type:        schema.TypeString,
-					Required:    true,
-					Description: "Uplink name from UplinkHostSwitch profile",
+					Type:         schema.TypeString,
+					Required:     true,
+					Description:  "Uplink name from UplinkHostSwitch profile",
+					ValidateFunc: validation.StringIsNotWhiteSpace,
 				},
 				"vds_lag_name": {
 					Type:        schema.TypeString,
@@ -611,6 +613,7 @@ func getHostSwitchProfileIDsSchema() *schema.Schema {
 		Elem: &schema.Schema{
 			Type: schema.TypeString,
 		},
+		ValidateFunc: validateNonEmptyList,
 	}
 }
 

diff --git a/nsxt/validators.go b/nsxt/validators.go
@@ -560,3 +560,17 @@ func validateLdapOrLdapsURL() schema.SchemaValidateFunc {
 		return
 	}
 }
+
+func validateNonEmptyList(i interface{}, k string) (warnings []string, errors []error) {
+	v, ok := i.([]interface{})
+	if !ok {
+		errors = append(errors, fmt.Errorf("expected type of %q to be List", k))
+		return warnings, errors
+	}
+
+	if len(v) == 0 {
+		errors = append(errors, fmt.Errorf("expected %q to be non-empty", k))
+	}
+
+	return warnings, errors
+}