Implement nsxt_edge_transport_node data source #1030
Merged
+172
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksamoray
force-pushed
the
ds-transport-node
branch
2 times, most recently
from
2c45492 to
861daac
Compare
|
/test-all |
ksamoray
changed the title
ksamoray
force-pushed
the
ds-transport-node
branch
from
861daac to
49a9141
Compare
|
/test-all |
annakhm
reviewed
Nov 14, 2023
| "id": getDataSourceIDSchema(), | ||
| "display_name": getDataSourceExtendedDisplayNameSchema(), | ||
| "description": getDescriptionSchema(), | ||
| "node_type": { |
There was a problem hiding this comment.
Would it make sense to filter by node type as well?
There was a problem hiding this comment.
Would that produce a unique result, other than in testing environments?
There was a problem hiding this comment.
Seems to me like such filtering could be helpful, but we can wait for the ask
There was a problem hiding this comment.
Maybe it's better to wait and see if we want to convert this into nsxt_edge_transport_node as discussed? Or maybe we change only the resource?
There was a problem hiding this comment.
I don't really have a preference, either is fine I think
annakhm
approved these changes
Nov 22, 2023
Signed-off-by: Kobi Samoray <[email protected]>
ksamoray
force-pushed
the
ds-transport-node
branch
from
49a9141 to
5023870
Compare
ksamoray
changed the title
|
/test-all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.