Skip to content

Commit

Permalink
Implement nsxt_transport_node resource
Browse files Browse the repository at this point in the history
Signed-off-by: Kobi Samoray <[email protected]>
  • Loading branch information
ksamoray committed Nov 14, 2023
1 parent 29d383f commit 2c45492
Show file tree
Hide file tree
Showing 4 changed files with 172 additions and 0 deletions.
99 changes: 99 additions & 0 deletions nsxt/data_source_nsxt_transport_node.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,99 @@
/* Copyright © 2023 VMware, Inc. All Rights Reserved.
SPDX-License-Identifier: MPL-2.0 */

package nsxt

import (
"fmt"

Check failure on line 7 in nsxt/data_source_nsxt_transport_node.go

View workflow job for this annotation

GitHub Actions / lint

File is not `goimports`-ed (goimports)
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
"github.com/vmware/vsphere-automation-sdk-go/runtime/bindings"
"github.com/vmware/vsphere-automation-sdk-go/services/nsxt-mp/nsx"
"github.com/vmware/vsphere-automation-sdk-go/services/nsxt-mp/nsx/model"
"strings"
)

func dataSourceNsxtTransportNode() *schema.Resource {
return &schema.Resource{
Read: dataSourceNsxtTransportNodeRead,

Schema: map[string]*schema.Schema{
"id": getDataSourceIDSchema(),
"display_name": getDataSourceExtendedDisplayNameSchema(),
"description": getDescriptionSchema(),
"node_type": {
Type: schema.TypeString,
Description: "Type of NSX transport node",
Optional: true,
Computed: true,
},
},
}
}

func dataSourceNsxtTransportNodeRead(d *schema.ResourceData, m interface{}) error {
connector := getPolicyConnector(m)
client := nsx.NewTransportNodesClient(connector)

objID := d.Get("id").(string)
objName := d.Get("display_name").(string)

var obj model.TransportNode

if objID != "" {
// Get by id
objGet, err := client.Get(objID)
if err != nil {
return fmt.Errorf("failed to read TransportNode %s: %v", objID, err)
}
obj = objGet
} else {
// Get by full name/prefix
objList, err := client.List(nil, nil, nil, nil, nil, nil, nil, nil, nil, nil)
if err != nil {
return fmt.Errorf("failed to read Transport Nodes: %v", err)
}
// go over the list to find the correct one (prefer a perfect match. If not - prefix match)
var perfectMatch []model.TransportNode
var prefixMatch []model.TransportNode
for _, objInList := range objList.Results {
if len(objName) == 0 {
// We want to grab single Transport Node
perfectMatch = append(perfectMatch, objInList)
continue
}
if strings.HasPrefix(*objInList.DisplayName, objName) {
prefixMatch = append(prefixMatch, objInList)
}
if *objInList.DisplayName == objName {
perfectMatch = append(perfectMatch, objInList)
}
}
if len(perfectMatch) > 0 {
if len(perfectMatch) > 1 {
return fmt.Errorf("found multiple Transport Nodes matching the criteria")
}
obj = perfectMatch[0]
} else if len(prefixMatch) > 0 {
if len(prefixMatch) > 1 {
return fmt.Errorf("found multiple Transport Nodes matching the criteria")
}
obj = prefixMatch[0]
} else {
return fmt.Errorf("no Transport Node matches the criteria")
}
}
d.SetId(*obj.Id)
d.Set("display_name", obj.DisplayName)
d.Set("description", obj.Description)

converter := bindings.NewTypeConverter()
base, errs := converter.ConvertToGolang(obj.NodeDeploymentInfo, model.NodeBindingType())
if errs != nil {
return errs[0]
}
node := base.(model.Node)

d.Set("node_type", node.ResourceType)

return nil
}
42 changes: 42 additions & 0 deletions nsxt/data_source_nsxt_transport_node_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
/* Copyright © 2023 VMware, Inc. All Rights Reserved.
SPDX-License-Identifier: MPL-2.0 */

package nsxt

import (
"fmt"
"testing"

"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
)

func TestAccDataSourceNsxtTransportNode_basic(t *testing.T) {
htnName := getHostTransportNodeName()
testResourceName := "data.nsxt_transport_node.test"

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() {
testAccOnlyLocalManager(t)
testAccPreCheck(t)
testAccEnvDefined(t, "NSXT_TEST_HOST_TRANSPORT_NODE")
},
Providers: testAccProviders,
Steps: []resource.TestStep{
{
Config: testAccNSXTransportNodeReadTemplate(htnName),
Check: resource.ComposeTestCheckFunc(
resource.TestCheckResourceAttr(testResourceName, "display_name", htnName),
resource.TestCheckResourceAttrSet(testResourceName, "id"),
resource.TestCheckResourceAttrSet(testResourceName, "node_type"),
),
},
},
})
}

func testAccNSXTransportNodeReadTemplate(name string) string {
return fmt.Sprintf(`
data "nsxt_transport_node" "test" {
display_name = "%s"
}`, name)
}
1 change: 1 addition & 0 deletions nsxt/provider.go
Original file line number Diff line number Diff line change
Expand Up @@ -292,6 +292,7 @@ func Provider() *schema.Provider {
"nsxt_compute_collection": dataSourceNsxtComputeCollection(),
"nsxt_compute_manager_realization": dataSourceNsxtComputeManagerRealization(),
"nsxt_policy_host_transport_node": dataSourceNsxtPolicyHostTransportNode(),
"nsxt_transport_node": dataSourceNsxtTransportNode(),
},

ResourcesMap: map[string]*schema.Resource{
Expand Down
30 changes: 30 additions & 0 deletions website/docs/d/transport_node.html.markdown
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
---
subcategory: "Beta"
layout: "nsxt"
page_title: "NSXT: transport_node"
description: A Transport Node data source.
---

# nsxt_transport_node

This data source provides information about a Transport Node configured on NSX.

## Example Usage

```hcl
data "nsxt_transport_node" "test_node" {
display_name = "edgenode1"
}
```

## Argument Reference

* `id` - (Optional) The ID of Transport Node to retrieve
* `display_name` - (Optional) The Display Name of the Transport Node to retrieve.

## Attributes Reference

In addition to arguments listed above, the following attributes are exported:

* `description` - The description of the resource.
* `node_type` - The type of the transport node. One of: 'HostNode', 'EdgeNode' or 'PublicCloudGatewayNode'.

0 comments on commit 2c45492

Please sign in to comment.