Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added esxi connection test before ssh test #98

Merged
merged 1 commit into from
Feb 16, 2024
Merged

fix: added esxi connection test before ssh test #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ Bugfix:

- Added support to `PowerManagement-ManagmentDomain.ps1` and `PowerManagement-WorkloadDomain.ps1` for vSAN File Services to be excluded from customer virtual machines. [GH-95](https://github.com/vmware/powershell-module-for-vmware-cloud-foundation-power-management/pull/95)
- Added exit to Tanzu Code in `PowerManagement-WorkloadDomain.ps1`[GH-97](https://github.com/vmware/powershell-module-for-vmware-cloud-foundation-power-management/pull/97)
- Added support to `PowerManagement-ManagmentDomain.ps1` and `PowerManagement-WorkloadDomain.ps1` for testing ESXi host connection before SSH connection. [GH-98](https://github.com/vmware/powershell-module-for-vmware-cloud-foundation-power-management/pull/98)

Enhancement:

Expand Down
108 changes: 72 additions & 36 deletions SampleScripts/PowerManagement-ManagementDomain.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,23 +274,36 @@ if ($PsBoundParameters.ContainsKey("shutdown") -or $PsBoundParameters.ContainsKe
}
# Checks SSH Status, if SSH service is not started, SSH will be started
if (Test-vSphereAuthentication -server $vcfVcenterDetails.fqdn -user $vcfVcenterDetails.ssoAdmin -pass $vcfVcenterDetails.ssoAdminPass) {
if ([float]$vcfVersion -lt [float]4.5) {
# Disable cluster member updates from vCenter Server
$esxihosts = (Get-VCFHost | Select-Object fqdn -ExpandProperty cluster | Where-Object { $_.id -eq $clusterid.id }).fqdn
if ([float]$vcfVersion -lt [float]4.5) {
# Disable cluster member updates from vCenter Server
$esxihosts = (Get-VCFHost | Select-Object fqdn -ExpandProperty cluster | Where-Object { $_.id -eq $clusterid.id }).fqdn
foreach ($esxi in $esxihosts) {
$password = (Get-VCFCredential -resourceName $esxi | Select-Object password)
$esxihostpassword = $password.password[1]
$status = Get-SSHEnabledStatus -server $esxi -user root -pass $esxihostpassword
if (!$status) {
if (Test-vSphereAuthentication -server $esxi -user root -pass $esxihostpassword) {
Get-VmHostService -VMHost $esxi | Where-Object { $_.key -eq "TSM-SSH" } | Start-VMHostService
Write-Output "Setting ESXi host $esxi to ignoreClusterMemberListUpdates..."
Invoke-EsxCommand -server $esxi -user root -pass $esxihostpassword -expected "Value of IgnoreClusterMemberListUpdates is 1" -cmd "esxcfg-advcfg -s 1 /VSAN/IgnoreClusterMemberListUpdates"
}
if (-Not (Test-VsphereConnection -server $esxiNode)) {
Write-PowerManagementLogMessage -Type ERROR "ESXi host $esxi is not accessible. Exiting..."
Exit
} else {
if (Test-vSphereAuthentication -server $esxi -user root -pass $esxihostpassword) {
Write-Output "Setting ESXi host $esxi to ignoreClusterMemberListUpdates..."
Invoke-EsxCommand -server $esxi -user root -pass $esxihostpassword -expected "Value of IgnoreClusterMemberListUpdates is 1" -cmd "esxcfg-advcfg -s 1 /VSAN/IgnoreClusterMemberListUpdates"
$password = (Get-VCFCredential -resourceName $esxi | Select-Object password)
$esxihostpassword = $password.password[1]
$status = Get-SSHEnabledStatus -server $esxi -user root -pass $esxihostpassword
if (-Not $status) {
if (Test-vSphereAuthentication -server $esxi -user root -pass $esxihostpassword) {
Write-PowerManagementLogMessage -Type WARNING "SSH is not enabled on ESXi host $esx. Enabling SSH..."
Get-VmHostService -VMHost $esxi | Where-Object { $_.key -eq "TSM-SSH" } | Start-VMHostService
Start-Sleep -s 10
Write-PowerManagementLogMessage -Type INFO "Setting ESXi host $esxi to ignoreClusterMemberListUpdates..."
Invoke-EsxCommand -server $esxi -user root -pass $esxihostpassword -expected "Value of IgnoreClusterMemberListUpdates is 1" -cmd "esxcfg-advcfg -s 1 /VSAN/IgnoreClusterMemberListUpdates"
} else {
Write-PowerManagementLogMessage -Type ERROR "Unable to authenticate to ESXi host $esxi. Exiting..."
Exit
}
} else {
if (Test-vSphereAuthentication -server $esxi -user root -pass $esxihostpassword) {
Write-PowerManagementLogMessage -Type INFO "Setting ESXi host $esxi to ignoreClusterMemberListUpdates..."
Invoke-EsxCommand -server $esxi -user root -pass $esxihostpassword -expected "Value of IgnoreClusterMemberListUpdates is 1" -cmd "esxcfg-advcfg -s 1 /VSAN/IgnoreClusterMemberListUpdates"
} else {
Write-PowerManagementLogMessage -Type ERROR "Unable to authenticate to ESXi host $esxi. Exiting..."
Exit
}
}
}
}
Expand Down Expand Up @@ -552,15 +565,20 @@ if ($PsBoundParameters.ContainsKey("shutdown") -or $PsBoundParameters.ContainsKe
# Check if SSH is enabled on the ESXI hosts before proceeding with the shutdown procedure.
Try {
foreach ($esxiNode in $esxiWorkloadDomain) {
$status = Get-SSHEnabledStatus -server $esxiNode.fqdn -user $esxiNode.username -pass $esxiNode.password
if (-Not $status) {
Write-PowerManagementLogMessage -Type ERROR -Message "Cannot open an SSH connection to host $($esxiNode.fqdn). If SSH is not enabled, follow the steps in the documentation to enable it."
if (Test-VsphereConnection -server $esxiNode) {
$status = Get-SSHEnabledStatus -server $esxiNode.fqdn -user $esxiNode.username -pass $esxiNode.password
if (-Not $status) {
Write-PowerManagementLogMessage -Type ERROR -Message "Unable to establish an SSH connection to ESXi host $($esxiNode.fqdn). SSH is not enabled. Exiting..."
Exit
}
} else {
Write-PowerManagementLogMessage -Type ERROR -Message "Unable to connect to ESXi host $($esxiNode.fqdn). Exiting..."
Exit
}
}
}
catch {
Write-PowerManagementLogMessage -Type ERROR -Message "Cannot open an SSH connection to host $($esxiNode.fqdn). If SSH is not enabled, follow the steps in the documentation to enable it."
} catch {
Write-PowerManagementLogMessage -Type ERROR -Message $_.Exception.Message
Exit
}
} else {
#Lockdown mode - if enabled on any host, stop the script
Expand Down Expand Up @@ -1043,14 +1061,20 @@ if ($PsBoundParameters.ContainsKey("startup")) {
#Check if SSH is enabled on the esxi hosts before proceeding with startup procedure
Try {
foreach ($esxiNode in $esxiWorkloadDomain) {
$status = Get-SSHEnabledStatus -server $esxiNode.fqdn -user $esxiNode.username -pass $esxiNode.password
if (-Not $status) {
Write-PowerManagementLogMessage -Type ERROR -Message "Cannot open an SSH connection to host $($esxiNode.fqdn). If SSH is not enabled, follow the steps in the documentation to enable it."
if (Test-VsphereConnection -server $esxiNode) {
$status = Get-SSHEnabledStatus -server $esxiNode.fqdn -user $esxiNode.username -pass $esxiNode.password
if (-Not $status) {
Write-PowerManagementLogMessage -Type ERROR -Message "Unable to establish an SSH connection to ESXi host $($esxiNode.fqdn). SSH is not enabled. Exiting..."
Exit
}
} else {
Write-PowerManagementLogMessage -Type ERROR -Message "Unable to connect to ESXi host $($esxiNode.fqdn). Exiting..."
Exit
}
}
} catch {
Write-PowerManagementLogMessage -Type ERROR -Message "Cannot open an SSH connection to host $($esxiNode.fqdn). If SSH is not enabled, follow the steps in the documentation to enable it."
Write-PowerManagementLogMessage -Type ERROR -Message $_.Exception.Message
Exit
}

# Take hosts out of maintenance mode
Expand Down Expand Up @@ -1221,19 +1245,31 @@ if ($PsBoundParameters.ContainsKey("startup")) {
if (-Not (Test-VsphereConnection -server $esxiNode)) {
Write-PowerManagementLogMessage -Type WARNING "ESXi host $esxiNode is not powered on...."
} else {
$password = (Get-VCFCredential -resourceName $esxiNode| Select-Object password)
$password = (Get-VCFCredential -resourceName $esxiNode | Select-Object password)
$esxihostpassword = $password.password[1]
$status = Get-SSHEnabledStatus -server $esxiNode-user root -pass $esxihostpassword
if (!$status) {
if (Test-vSphereAuthentication -server $esxiNode-user root -pass $esxihostpassword) {
Get-VmHostService -VMHost $esxiNode | Where-Object { $_.key -eq "TSM-SSH" } | Start-VMHostService
Set-MaintenanceMode -server $esxiNode -user root -pass $esxihostpassword -state DISABLE
}
} else {
if (Test-vSphereAuthentication -server $esxiNode -user root -pass $esxihostpassword) {
Set-MaintenanceMode -server $esxiNode -user root -pass $esxihostpassword -state DISABLE
$status = Get-SSHEnabledStatus -server $esxiNode -user root -pass $esxihostpassword
if (-Not $status) {
if (Test-vSphereAuthentication -server $esxi -user root -pass $esxihostpassword) {
Write-PowerManagementLogMessage -Type WARNING "SSH is not enabled on $esxiNode, enabling it now..."
Get-VmHostService -VMHost $esxiNode | Where-Object { $_.key -eq "TSM-SSH" } | Start-VMHostService
Start-Sleep -s 10
Write-PowerManagementLogMessage -Type INFO "Attempting to Set Maintenance Mode on $esxiNode to DISABLE"
burnsjared0415 marked this conversation as resolved.
Show resolved Hide resolved
Set-MaintenanceMode -server $esxiNode -user root -pass $esxihostpassword -state DISABLE
Start-Sleep -s 120
} else {
Write-PowerManagementLogMessage -Type ERROR "Unable to authenticate to $esxiNode. Exiting..."
Exit
}
} else {
if (Test-vSphereAuthentication -server $esxi -user root -pass $esxihostpassword) {
Write-PowerManagementLogMessage -Type INFO "Attempting to Set Maintenance Mode on $esxiNode to DISABLE"
burnsjared0415 marked this conversation as resolved.
Show resolved Hide resolved
Set-MaintenanceMode -server $esxiNode -user root -pass $esxihostpassword -state DISABLE
Start-Sleep -s 120
} else {
Write-PowerManagementLogMessage -Type ERROR "Unable to authenticate to $esxiNode. Exiting..."
Exit
}
}
}
}
}
Write-PowerManagementLogMessage -Type INFO -Message "Pausing for 30 seconds while hosts come out of maintenance mode..."
Expand Down
22 changes: 14 additions & 8 deletions SampleScripts/PowerManagement-WorkloadDomain.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,20 +443,26 @@ Try {
# For versions prior VCF 4.5
# Check if SSH is enabled on the esxi hosts before proceeding with startup procedure
Try {
foreach ($esxiNode in $esxiDetails) {
$status = Get-SSHEnabledStatus -server $esxiNode.fqdn -user $esxiNode.username -pass $esxiNode.password
if (-Not $status) {
Write-PowerManagementLogMessage -Type ERROR -Message "Cannot open an SSH connection to host $($esxiNode.fqdn). If SSH is not enabled, follow the steps in the documentation to enable it."
foreach ($esxiNode in $esxiWorkloadDomain) {
if (Test-VsphereConnection -server $esxiNode) {
$status = Get-SSHEnabledStatus -server $esxiNode.fqdn -user $esxiNode.username -pass $esxiNode.password
if (-Not $status) {
Write-PowerManagementLogMessage -Type ERROR -Message "Unable to establish an SSH connection to ESXi host $($esxiNode.fqdn). SSH is not enabled. Exiting..."
Exit
}
} else {
Write-PowerManagementLogMessage -Type ERROR -Message "Unable to connect to ESXi host $($esxiNode.fqdn). Exiting..."
Exit
}
}
}
catch {
Write-PowerManagementLogMessage -Type ERROR -Message "Cannot open an SSH connection to host $($esxiNode.fqdn), If SSH is not enabled, follow the steps in the documentation to enable it."
} catch {
Write-PowerManagementLogMessage -Type ERROR -Message $_.Exception.Message
Exit
}
} else {
foreach ($esxiNode in $esxiDetails) {
if (!(Test-EndpointConnection -server $esxiNode.fqdn -Port 443)) {
Write-PowerManagementLogMessage -Type ERROR -Message "Cannot communicate with the host $($esxiNode.fqdn). Check the FQDN or IP address, or the power state of '$($esxiNode.fqdn)'."
Write-PowerManagementLogMessage -Type ERROR -Message "Unable to communicate with ESXi host $($esxiNode.fqdn). Check the FQDN or IP address, or the power state. Exiting..."
Exit
}
}
Expand Down
2 changes: 1 addition & 1 deletion VMware.CloudFoundation.PowerManagement.psd1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
RootModule = 'VMware.CloudFoundation.PowerManagement.psm1'

# Version number of this module.
ModuleVersion = '1.4.1.1008'
ModuleVersion = '1.4.1.1009'

# Supported PSEditions
# CompatiblePSEditions = @()
Expand Down