Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: added esxi connection test before ssh test #98

Merged
merged 1 commit into from
Feb 16, 2024
Merged

fix: added esxi connection test before ssh test #98

merged 1 commit into from
Feb 16, 2024

Conversation

burnsjared0415
Copy link
Contributor

Summary

Added support to PowerManagement-ManagmentDomain.ps1 and PowerManagement-WorkloadDomain.ps1 for testing esxi connection before testing ssh command.

Type

  • Bugfix
  • Enhancement or Feature
  • Code Style or Formatting
  • Documentation
  • Refactoring
  • Chore
  • Other
    Please describe:

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

Test and Documentation

  • Tests have been completed.
  • Documentation has been added or updated.

Issue References

Closes #49

Additional Information

@github-actions github-actions bot added documentation Documentation needs-review Needs Review labels Feb 15, 2024
@burnsjared0415 burnsjared0415 force-pushed the fix/added-connection-test-for-esxi-hosts branch from a8aa3cb to 6b520a4 Compare February 15, 2024 21:35
@tenthirtyam tenthirtyam marked this pull request as ready for review February 16, 2024 11:37
@tenthirtyam tenthirtyam requested a review from a team as a code owner February 16, 2024 11:37
@tenthirtyam tenthirtyam self-requested a review February 16, 2024 11:37
@tenthirtyam tenthirtyam added this to the v1.4.1 milestone Feb 16, 2024
@tenthirtyam tenthirtyam force-pushed the fix/added-connection-test-for-esxi-hosts branch 2 times, most recently from a5d9de7 to 172c1a4 Compare February 16, 2024 14:19
@tenthirtyam tenthirtyam force-pushed the fix/added-connection-test-for-esxi-hosts branch 2 times, most recently from cbfdec3 to 31f3cde Compare February 16, 2024 14:32
@tenthirtyam tenthirtyam force-pushed the fix/added-connection-test-for-esxi-hosts branch 2 times, most recently from d1308e4 to b748d30 Compare February 16, 2024 14:39
tenthirtyam
tenthirtyam requested changes Feb 16, 2024
View reviewed changes
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed some messages and force pushed but left some changes here for review and update.

@burnsjared0415
fix: added esxi connection test before ssh
77bf751 
Added support to `PowerManagement-ManagmentDomain.ps1` and `PowerManagement-WorkloadDomain.ps1` for testing ESXi host connection before SSH connection.

Signed-off-by: Jared Burns <[email protected]>
@burnsjared0415 burnsjared0415 force-pushed the fix/added-connection-test-for-esxi-hosts branch from b748d30 to 77bf751 Compare February 16, 2024 16:15
tenthirtyam
tenthirtyam approved these changes Feb 16, 2024
View reviewed changes
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tenthirtyam tenthirtyam merged commit efb0149 into vmware:develop Feb 16, 2024
1 check passed
@tenthirtyam tenthirtyam removed the needs-review Needs Review label Feb 16, 2024
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2024
@tenthirtyam tenthirtyam removed this from the v1.4.1 milestone Jul 15, 2024
@tenthirtyam tenthirtyam modified the milestones: v1.4.2, v1.4.1 Jul 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tenthirtyam tenthirtyam tenthirtyam approved these changes

Assignees

@burnsjared0415 burnsjared0415

Labels
documentation Documentation
Projects
None yet
Milestone
v1.4.1
Development

Successfully merging this pull request may close these issues.

Error: "unable to SSH to host <host-fqdn>" returned when an ESXi host is in disconnected state
2 participants
@burnsjared0415 @tenthirtyam