-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve the linter issue. #7707
Conversation
7a67256
to
231643e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7707 +/- ##
=======================================
Coverage 58.49% 58.49%
=======================================
Files 343 343
Lines 28486 28486
=======================================
Hits 16664 16664
Misses 10406 10406
Partials 1416 1416 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Xun Jiang <[email protected]>
231643e
to
48301e7
Compare
Hi @blackpiglet , Would you merge my PR and then complete it with this one ? |
@@ -44,7 +35,7 @@ run: | |||
# output configuration options | |||
output: | |||
# colored-line-number|line-number|json|tab|checkstyle|code-climate, default is "colored-line-number" | |||
format: colored-line-number | |||
formats: colored-line-number |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
formats: colored-line-number | |
formats: | |
- format: colored-line-number | |
path: stdout |
Thanks for your contribution, and sorry for not realizing your PR's value earlier. At first, I thought the linter action didn't print the issued line number and the reported linter is due to the configuration file name. |
No worries, things aren’t always obvious 🤗. |
related work #7194 (I will be able to work on that PR again only on may 13) |
Close because the fix is already merged with #7697 |
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
/kind changelog-not-required
as a comment on this pull request.site/content/docs/main
.