-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
organize golangci workflow #7595
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7595 +/- ##
=======================================
Coverage 58.66% 58.66%
=======================================
Files 345 345
Lines 28733 28733
=======================================
Hits 16856 16856
Misses 10448 10448
Partials 1429 1429 ☔ View full report in Codecov by Sentry. |
conflicts with #7194 |
Yes, it’s on purpose because with a rebase after this one is merged the modification done in 7194 concering golangci-lint config are going to be easier to review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can rebase my PR afterwards
bc35096
to
272cc32
Compare
272cc32
to
72d7b33
Compare
Sorry, the rebase dismissed your reviews |
CI failed due to throttling, rerunning it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest not to change the configuration file name.
I'm trying to use golangci/golangci-lint-action@v4
to replace the make lint
in the lint action.
And the GitHub action cannot find files those names start with .
.
.golangci.yaml is one of the default file handled by golangci-lint so you won't need to customize the golangci config file, it will work out of the box, I can complete this PR to package it if you want ? |
Please take a view of this commit. The linter's output is not formatted if it doesn't pass the configuration file parameter. |
ba0289d
to
b76dbc8
Compare
e4cff67
to
a0c1431
Compare
11659e9
to
151b622
Compare
ab21689
to
70a46ac
Compare
6aee83f
to
42990bf
Compare
@blackpiglet , |
We need the maintainers' approval to merge the PR. |
Signed-off-by: Matthieu MOREL <[email protected]>
42990bf
to
bc1e88c
Compare
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
/kind changelog-not-required
as a comment on this pull request.site/content/docs/main
.