[cherry-pick]Make "disable-informer-cache" option false(enabled) by default to keep it consistent with the help message #7298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't merge it until v1.12.3 is released |
ywk253100
force-pushed
the
240110_informer_cache
branch
from
f3e7866 to
56a4202
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.12 #7298 +/- ##
================================================
+ Coverage 60.58% 60.60% +0.02%
================================================
Files 251 251
Lines 26791 26791
================================================
+ Hits 16230 16238 +8
+ Misses 9408 9401 -7
+ Partials 1153 1152 -1 ☔ View full report in Codecov by Sentry. |
ywk253100
force-pushed
the
240110_informer_cache
branch
from
56a4202 to
85a5b0e
Compare
|
The PR is ready to review as v1.12.3 is released |
ywk253100
force-pushed
the
240110_informer_cache
branch
from
85a5b0e to
7b1cb5a
Compare
…p it consistent with the help message Make "disable-informer-cache" option false(enabled) by default to keep it consi stent with the help message Fixes vmware-tanzu#7264 Signed-off-by: Wenkai Yin(尹文开) <[email protected]>
ywk253100
force-pushed
the
240110_informer_cache
branch
from
7b1cb5a to
1cc6f74
Compare
blackpiglet
approved these changes
Jan 18, 2024
reasonerjt
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make "disable-informer-cache" option false(enabled) by default to keep it consi stent with the help message
Fixes #7264
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.