Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The help message and actual behavior for disable-informer-cache mismatch in install CLI #7264

Closed
ywk253100 opened this issue Jan 3, 2024 · 0 comments · Fixed by #7294
Closed

Comments

@ywk253100
Copy link
Contributor

The help message says Default is false (don't disable) but the actual behavior is disabled by default.

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

  • 👍 for "I would like to see this bug fixed as soon as possible"
  • 👎 for "There are more important bugs to focus on right now"
@ywk253100 ywk253100 added this to the v1.13 milestone Jan 3, 2024
@ywk253100 ywk253100 self-assigned this Jan 3, 2024
ywk253100 added a commit to ywk253100/velero that referenced this issue Jan 4, 2024
Make informer cache disabled by default

Fixes vmware-tanzu#7264

Signed-off-by: Wenkai Yin(尹文开) <[email protected]>
ywk253100 added a commit to ywk253100/velero that referenced this issue Jan 8, 2024
Make informer cache disabled by default

Fixes vmware-tanzu#7264

Signed-off-by: Wenkai Yin(尹文开) <[email protected]>
ywk253100 added a commit to ywk253100/velero that referenced this issue Jan 8, 2024
Make informer cache disabled by default

Fixes vmware-tanzu#7264

Signed-off-by: Wenkai Yin(尹文开) <[email protected]>
ywk253100 added a commit to ywk253100/velero that referenced this issue Jan 8, 2024
Make informer cache disabled by default

Fixes vmware-tanzu#7264

Signed-off-by: Wenkai Yin(尹文开) <[email protected]>
ywk253100 added a commit to ywk253100/velero that referenced this issue Jan 10, 2024
…p it consistent with the help message

Make "disable-informer-cache" option false(enabled) by default to keep it consi
stent with the help message

Fixes vmware-tanzu#7264

Signed-off-by: Wenkai Yin(尹文开) <[email protected]>
ywk253100 added a commit to ywk253100/velero that referenced this issue Jan 10, 2024
…p it consistent with the help message

Make "disable-informer-cache" option false(enabled) by default to keep it consi
stent with the help message

Fixes vmware-tanzu#7264

Signed-off-by: Wenkai Yin(尹文开) <[email protected]>
ywk253100 added a commit to ywk253100/velero that referenced this issue Jan 10, 2024
…p it consistent with the help message

Make "disable-informer-cache" option false(enabled) by default to keep it consi
stent with the help message

Fixes vmware-tanzu#7264

Signed-off-by: Wenkai Yin(尹文开) <[email protected]>
ywk253100 added a commit to ywk253100/velero that referenced this issue Jan 10, 2024
…p it consistent with the help message

Make "disable-informer-cache" option false(enabled) by default to keep it consi
stent with the help message

Fixes vmware-tanzu#7264

Signed-off-by: Wenkai Yin(尹文开) <[email protected]>
ywk253100 added a commit to ywk253100/velero that referenced this issue Jan 12, 2024
…p it consistent with the help message

Make "disable-informer-cache" option false(enabled) by default to keep it consi
stent with the help message

Fixes vmware-tanzu#7264

Signed-off-by: Wenkai Yin(尹文开) <[email protected]>
ywk253100 added a commit to ywk253100/velero that referenced this issue Jan 16, 2024
…p it consistent with the help message

Make "disable-informer-cache" option false(enabled) by default to keep it consi
stent with the help message

Fixes vmware-tanzu#7264

Signed-off-by: Wenkai Yin(尹文开) <[email protected]>
ywk253100 added a commit to ywk253100/velero that referenced this issue Jan 18, 2024
…p it consistent with the help message

Make "disable-informer-cache" option false(enabled) by default to keep it consi
stent with the help message

Fixes vmware-tanzu#7264

Signed-off-by: Wenkai Yin(尹文开) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment