Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cherry-pick][1.12] RM support for Escaped bool, float, null (#7118) #7131

Merged

Conversation

anshulahuja98
Copy link
Collaborator

  • RM support for Escaped bool, float, null

  • fix ci


Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

* RM support for Escaped bool, float, null

Signed-off-by: Anshul Ahuja <[email protected]>

* fix ci

Signed-off-by: Anshul Ahuja <[email protected]>

---------

Signed-off-by: Anshul Ahuja <[email protected]>
@anshulahuja98
Copy link
Collaborator Author

/kind changelog-not-required

@anshulahuja98 anshulahuja98 marked this pull request as ready for review November 21, 2023 03:52
@github-actions github-actions bot added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Nov 21, 2023
@anshulahuja98 anshulahuja98 changed the title RM support for Escaped bool, float, null (#7118) [Cherry-pick][1.12] RM support for Escaped bool, float, null (#7118) Nov 21, 2023
@anshulahuja98 anshulahuja98 requested review from reasonerjt and removed request for shubham-pampattiwar November 21, 2023 03:53
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b684862) 60.54% compared to head (c836bde) 60.54%.

Files Patch % Lines
internal/resourcemodifiers/json_patch.go 91.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.12    #7131      +/-   ##
================================================
- Coverage         60.54%   60.54%   -0.01%     
================================================
  Files               251      251              
  Lines             26688    26693       +5     
================================================
+ Hits              16159    16161       +2     
- Misses             9392     9394       +2     
- Partials           1137     1138       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anshulahuja98 anshulahuja98 merged commit 06d12de into vmware-tanzu:release-1.12 Nov 23, 2023
27 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants