Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RM support for Escaped bool, float, null #7118

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

anshulahuja98
Copy link
Collaborator

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #7104

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

Signed-off-by: Anshul Ahuja <[email protected]>
@anshulahuja98
Copy link
Collaborator Author

/kind changelog-not-required

@github-actions github-actions bot added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Nov 17, 2023
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (c283edf) 61.19% compared to head (9e18a16) 61.18%.

Files Patch % Lines
internal/resourcemodifiers/json_patch.go 91.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7118      +/-   ##
==========================================
- Coverage   61.19%   61.18%   -0.01%     
==========================================
  Files         258      258              
  Lines       27327    27332       +5     
==========================================
+ Hits        16722    16724       +2     
- Misses       9423     9425       +2     
- Partials     1182     1183       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anshulahuja98 anshulahuja98 marked this pull request as ready for review November 17, 2023 11:29
@blackpiglet blackpiglet self-requested a review November 20, 2023 06:17
@anshulahuja98 anshulahuja98 merged commit 0e53cd0 into vmware-tanzu:main Nov 21, 2023
26 of 28 checks passed
anshulahuja98 added a commit to anshulahuja98/velero that referenced this pull request Nov 21, 2023
* RM support for Escaped bool, float, null

Signed-off-by: Anshul Ahuja <[email protected]>

* fix ci

Signed-off-by: Anshul Ahuja <[email protected]>

---------

Signed-off-by: Anshul Ahuja <[email protected]>
anshulahuja98 added a commit that referenced this pull request Nov 23, 2023
* RM support for Escaped bool, float, null



* fix ci



---------

Signed-off-by: Anshul Ahuja <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes target/1.12.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Escaping of " in values for restore modified patches doesn't work
3 participants