Skip updating status when CRDs are restored #6325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reasonerjt
force-pushed
the
restore-progress
branch
from
1889dd4 to
8441e52
Compare
This commit skips updating the restore progress, in the first loop for restoration when CRDs are handled, so that the misleading "totalItem" will not appear in the CR. Fixes vmware-tanzu#5990 Signed-off-by: Daniel Jiang <[email protected]>
reasonerjt
force-pushed
the
restore-progress
branch
from
8441e52 to
89d5d6a
Compare
blackpiglet
approved these changes
May 31, 2023
ywk253100
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit skips updating the restore progress, in the first loop for restoration when CRDs are handled, so that the misleading "totalItem" will not appear in the CR.
Fixes #5990
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.