Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore progress is misleading (temporarily) #5990

Closed
rnarenpujari opened this issue Mar 16, 2023 · 1 comment · Fixed by #6325
Closed

Restore progress is misleading (temporarily) #5990

rnarenpujari opened this issue Mar 16, 2023 · 1 comment · Fixed by #6325

Comments

@rnarenpujari
Copy link

What steps did you take and what happened:

The Restore CR contains progress info in terms of number of items restored and the total number of items (link). The restore seems to happen in two passes - in the first pass, the totalItems reported is low (56 in my test) and itemsRestored reaches this value shortly. Then the second pass starts and totalItems is updated to a larger value (~2600 in my case) and eventually itemsRestored reaches this value after some time and the restore phase becomes completed.
The point here is that there is a transient state shortly after starting the restore where itemsRestored == totalItems even though the restore is not done which can be a bit misleading.

What did you expect to happen:

The restore progress to be reported in a single pass where itemsRestored < totalItems until the restore completes.

It is already documented that total items will be updated throughout the restore (link) so this is technically not a bug but can perhaps be handled better to avoid this transient incorrect state?

The following information will help us better understand what's going on:

NA

Anything else you would like to add:

NA

Environment:

  • Velero version (use velero version): 1.9.5
  • Velero features (use velero client config get features):
  • Kubernetes version (use kubectl version):
  • Kubernetes installer & version:
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

  • 👍 for "I would like to see this bug fixed as soon as possible"
  • 👎 for "There are more important bugs to focus on right now"
@reasonerjt
Copy link
Contributor

We will delay showing the number, so only when there's a relatively accurate number of objects this field will be updated.

reasonerjt added a commit to reasonerjt/velero that referenced this issue May 30, 2023
This commit skips updating the restore progress, in the first loop for
restoration when CRDs are handled, so that the misleading "totalItem"
will not appear in the CR.
Fixes vmware-tanzu#5990

Signed-off-by: Daniel Jiang <[email protected]>
reasonerjt added a commit to reasonerjt/velero that referenced this issue May 30, 2023
This commit skips updating the restore progress, in the first loop for
restoration when CRDs are handled, so that the misleading "totalItem"
will not appear in the CR.
Fixes vmware-tanzu#5990

Signed-off-by: Daniel Jiang <[email protected]>
reasonerjt added a commit to reasonerjt/velero that referenced this issue May 30, 2023
This commit skips updating the restore progress, in the first loop for
restoration when CRDs are handled, so that the misleading "totalItem"
will not appear in the CR.
Fixes vmware-tanzu#5990

Signed-off-by: Daniel Jiang <[email protected]>
ywk253100 pushed a commit that referenced this issue May 31, 2023
This commit skips updating the restore progress, in the first loop for
restoration when CRDs are handled, so that the misleading "totalItem"
will not appear in the CR.
Fixes #5990

Signed-off-by: Daniel Jiang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants