Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Golang 1.18 #3577

Merged
merged 1 commit into from
Oct 12, 2022
Merged

Golang 1.18 #3577

merged 1 commit into from
Oct 12, 2022

Conversation

seemiller
Copy link
Contributor

@seemiller seemiller commented Oct 6, 2022

What this PR does / why we need it

Golang 1.18

This is my second PR to merge 1.18 changes.

Describe testing done for PR

Release note

Golang 1.18

Additional information

Special notes for your reviewer

@github-actions
Copy link

github-actions bot commented Oct 6, 2022

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3577/20221006212257/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@github-actions
Copy link

github-actions bot commented Oct 6, 2022

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3577/20221006212521/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Merging #3577 (d29b21c) into main (7efdbec) will increase coverage by 0.08%.
The diff coverage is n/a.

❗ Current head d29b21c differs from pull request most recent head 952c14c. Consider uploading reports for the commit 952c14c to get more accurate results

@@            Coverage Diff             @@
##             main    #3577      +/-   ##
==========================================
+ Coverage   46.27%   46.35%   +0.08%     
==========================================
  Files         400      448      +48     
  Lines       39573    43871    +4298     
==========================================
+ Hits        18311    20337    +2026     
- Misses      19572    21759    +2187     
- Partials     1690     1775      +85     
Impacted Files Coverage Δ
cli/core/pkg/config/config.go 0.00% <0.00%> (-100.00%) ⬇️
cli/core/pkg/artifact/interface.go 0.00% <0.00%> (-100.00%) ⬇️
cli/core/pkg/artifact/http.go 0.00% <0.00%> (-80.49%) ⬇️
cli/core/pkg/config/bom.go 25.00% <0.00%> (-62.50%) ⬇️
cli/core/pkg/auth/csp/grpc.go 0.00% <0.00%> (-41.25%) ⬇️
cli/core/pkg/carvelhelpers/registry.go 0.00% <0.00%> (-35.42%) ⬇️
cli/core/pkg/config/defaults.go 41.50% <0.00%> (-33.97%) ⬇️
cli/core/pkg/auth/csp/token.go 64.70% <0.00%> (-18.79%) ⬇️
cli/core/pkg/auth/tkg/kube_config.go 51.87% <0.00%> (-15.04%) ⬇️
cli/core/pkg/carvelhelpers/package.go 54.28% <0.00%> (-14.29%) ⬇️
... and 66 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link

github-actions bot commented Oct 7, 2022

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3577/20221007152314/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@github-actions
Copy link

github-actions bot commented Oct 7, 2022

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3577/20221007203905/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3577/20221010184350/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@seemiller seemiller marked this pull request as ready for review October 10, 2022 19:31
@seemiller seemiller requested review from a team and prkalle as code owners October 10, 2022 19:31
@seemiller seemiller added the ok-to-merge PRs should be labelled with this before merging label Oct 11, 2022
@seemiller seemiller changed the title Golang 1.18, take 2 (#3508) Golang 1.18 Oct 11, 2022
@github-actions
Copy link

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/3577/20221011155624/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-not-required ok-to-merge PRs should be labelled with this before merging priority/critical-urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants