Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

[Tooling]Fix Go version #3568

Closed
wants to merge 1 commit into from

Conversation

marckhouzam
Copy link
Contributor

What this PR does / why we need it

We moved to go version with #3508, but these two new modules got added right after but the PR was opened before, so it contained the old go version (see #3425) .

Describe testing done for PR

Let CI run

cc @sathyanarays @seemiller

We moved to go version with vmware-tanzu#3508, but these two new modules got added
right after.

Signed-off-by: Marc Khouzam <[email protected]>
@marckhouzam marckhouzam requested a review from a team as a code owner October 6, 2022 12:38
@randomvariable randomvariable changed the title Fix Go version [Tooling]Fix Go version Oct 6, 2022
@randomvariable randomvariable added the ok-to-merge PRs should be labelled with this before merging label Oct 6, 2022
@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Merging #3568 (e546731) into main (59f44fd) will decrease coverage by 0.83%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3568      +/-   ##
==========================================
- Coverage   47.19%   46.35%   -0.84%     
==========================================
  Files         423      448      +25     
  Lines       42307    43871    +1564     
==========================================
+ Hits        19966    20338     +372     
- Misses      20579    21758    +1179     
- Partials     1762     1775      +13     
Impacted Files Coverage Δ
cmd/cli/plugin/tkr/v1alpha3/os.go 73.50% <0.00%> (-0.86%) ⬇️
cmd/cli/plugin/cluster/scale.go 17.85% <0.00%> (ø)
...i/plugin/cluster/delete_machinehealthcheck_node.go 16.66% <0.00%> (ø)
cmd/cli/plugin/cluster/list.go 9.52% <0.00%> (ø)
cmd/cli/plugin/cluster/delete_node_pool.go 16.66% <0.00%> (ø)
cmd/cli/plugin/cluster/machinehealthcheck.go 100.00% <0.00%> (ø)
cmd/cli/plugin/cluster/available_upgrade.go 16.32% <0.00%> (ø)
cmd/cli/plugin/cluster/get_node_pools.go 10.52% <0.00%> (ø)
...in/cluster/get_machinehealthcheck_control_plane.go 11.11% <0.00%> (ø)
cmd/cli/plugin/cluster/delete.go 12.50% <0.00%> (ø)
... and 19 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@marckhouzam marckhouzam added the do-not-merge/hold Some fixes necessary, hold for merging label Oct 6, 2022
@marckhouzam
Copy link
Contributor Author

We're going to hold on this as the change to Go 1.18 may be reverted by #3571

@marckhouzam
Copy link
Contributor Author

This is no longer needed after the new PR to move to Go 1.18 #3577

@marckhouzam marckhouzam deleted the fix/goversion branch October 12, 2022 12:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-not-required do-not-merge/hold Some fixes necessary, hold for merging ok-to-merge PRs should be labelled with this before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants