Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rolling up junit results on daemonset plugin incorrect #900

Closed
johnSchnake opened this issue Sep 24, 2019 · 0 comments · Fixed by #937
Closed

Rolling up junit results on daemonset plugin incorrect #900

johnSchnake opened this issue Sep 24, 2019 · 0 comments · Fixed by #937
Labels
kind/bug Behavior isn't as expected or intended p1-important

Comments

@johnSchnake
Copy link
Contributor

What steps did you take and what happened:
I had a plugin that ran a junit producing plugin on a 2 node cluster as a daemonset.

One of the nodes, which had test failures, did not get a status at all:

- name: kind-worker
  status: ""
  items:
  - name: output.xml
    status: failed
    meta:
      file: results/kind-worker/tmp/results/output.xml
    items:
    - name: benchmark
      status: failed
      items:
      - name: benchmark-1.7.1
        status: skipped

The other node in the cluster did get a properly bubbled-up failed status.

What did you expect to happen:
Each nodes results should be aggregated appropriately.

Anything else you would like to add:
At this time I don't want to share the plugin I was using as it is a WIP but I think the bug should be fairly easy to repro/identify in the code.
@johnSchnake johnSchnake added kind/bug Behavior isn't as expected or intended p1-important labels Sep 24, 2019
@johnSchnake johnSchnake mentioned this issue Oct 3, 2019
Merged
johnSchnake added a commit that referenced this issue Oct 3, 2019
@johnSchnake
Process all nodes and treat empty status as unknown (#937)
69cc7ff 
If a node isn't marked with a status, it should be treated as
being unknown and bubble up accordingly.

In addition, we need to continue processing all leaves instead
of exiting early on failure to ensure we bubble up every part
of the tree.

Fixes #900

Signed-off-by: John Schnake <[email protected]>
@johnSchnake johnSchnake mentioned this issue Oct 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Behavior isn't as expected or intended p1-important
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Process all nodes and treat empty status as unknown
1 participant
@johnSchnake