Process all nodes and treat empty status as unknown #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Small simple bug fix with 100% coverage. Merging after green in CI. Will rebase |
If a node isn't marked with a status, it should be treated as being unknown and bubble up accordingly. In addition, we need to continue processing all leaves instead of exiting early on failure to ensure we bubble up every part of the tree. Fixes #900 Signed-off-by: John Schnake <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #937 +/- ##
==========================================
+ Coverage 47.56% 47.58% +0.02%
==========================================
Files 76 76
Lines 5178 5180 +2
==========================================
+ Hits 2463 2465 +2
Misses 2565 2565
Partials 150 150
Continue to review full report at Codecov.
|
johnSchnake
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
If a node isn't marked with a status, it should be treated as
being unknown and bubble up accordingly.
Which issue(s) this PR fixes
Fixes #900
Special notes for your reviewer:
Release note: