Migrate release job to GitHub Actions #5600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jesús Benito Calzada <[email protected]>
✅ Deploy Preview for kubeapps-dev canceled.Built without sensitive environment variables
|
beni0888
added
component/ci
Signed-off-by: Jesús Benito Calzada <[email protected]>
antgamdia
approved these changes
Nov 2, 2022
There was a problem hiding this comment.
Thanks! +1, but before merging, please refer to my previous comment (#5590 (review)) about the EOF new lines.
ouch! I overlooked that comment, I'll fix it in this PR before merging it. |
added 2 commits
November 2, 2022 17:19
Signed-off-by: Jesús Benito Calzada <[email protected]>
Signed-off-by: Jesús Benito Calzada <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jesús Benito Calzada [email protected]
Description of the change
This PR contains the migration of the
releasejob to GitHub actions. A new workflow calledRelease Pipelinehas been created. It calls the reusablekubeapps-general.ymlworkflow passing the parameterrun_gke_testswith the valuetrue, and is triggered only on new version tags.Benefits
The release job has been migrated to GHA, so releases can be properly handled by the GitHub Actions pipeline.
Possible drawbacks
DEV_MODEenv var is equal totrue(as it is right now) the GitHub CLI call for actually triggering the release on GitHub is skipped and an informative message is printed instead.Applicable issues