Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yaml decoding fix #5531

Merged
merged 2 commits into from
Oct 21, 2022
Merged

Yaml decoding fix #5531

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88d4ac3
Decode yamlseq/yamlmap to js objects
antgamdia Oct 20, 2022
644660d
Merge branch '1-3535-customSchema' into 2-5519-yamlDecodingFix
antgamdia Oct 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion dashboard/src/shared/yamlUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,15 @@ export function getPathValueInYamlNode(
path: string,
) {
const splittedPath = parsePath(path);
const value = values?.getIn(splittedPath);
let value = values?.getIn(splittedPath);

// if the value from getIn is an object, it means
// it is a YamlSeq or YamlMap, so we need to convert it
// back to a plain JS object
if (typeof value === "object") {
value = (value as any)?.toJSON();
}

return value;
}

Expand Down