Yaml decoding fix #5531
Merged
Yaml decoding fix #5531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonio Gamez Diaz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
While working on #5436, I noticed some errors during the YAML parsing; well not errors, but unexpected (for me) values being returned by the
genInmethod. In collections, the returned thing is not a js object, but a custom data type from the YAML library.This PR is just to convert collections (YAML sequences and YAML maps) back to plain js objects (even if the function says
toJSON()😅Benefits
We will be able to use arrays and object fields in the form.
Possible drawbacks
N/A
Applicable issues
Additional information