-
Notifications
You must be signed in to change notification settings - Fork 707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the jobs sync from/to bitnami in the GHA's "kubeapps general" workflow #5524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jesús Benito Calzada <[email protected]>
Signed-off-by: Jesús Benito Calzada <[email protected]>
Signed-off-by: Jesús Benito Calzada <[email protected]>
Signed-off-by: Jesús Benito Calzada <[email protected]>
Signed-off-by: Jesús Benito Calzada <[email protected]>
Signed-off-by: Jesús Benito Calzada <[email protected]>
Signed-off-by: Jesús Benito Calzada <[email protected]>
Signed-off-by: Jesús Benito Calzada <[email protected]>
Signed-off-by: Jesús Benito Calzada <[email protected]>
Signed-off-by: Jesús Benito Calzada <[email protected]>
Signed-off-by: Jesús Benito Calzada <[email protected]>
Signed-off-by: Jesús Benito Calzada <[email protected]>
Signed-off-by: Jesús Benito Calzada <[email protected]>
Signed-off-by: Jesús Benito Calzada <[email protected]>
Signed-off-by: Jesús Benito Calzada <[email protected]>
Signed-off-by: Jesús Benito Calzada <[email protected]>
Signed-off-by: Jesús Benito Calzada <[email protected]>
Signed-off-by: Jesús Benito Calzada <[email protected]>
Signed-off-by: Jesús Benito Calzada <[email protected]>
Signed-off-by: Jesús Benito Calzada <[email protected]>
Signed-off-by: Jesús Benito Calzada <[email protected]>
Signed-off-by: Jesús Benito Calzada <[email protected]>
Signed-off-by: Jesús Benito Calzada <[email protected]>
Signed-off-by: Jesús Benito Calzada <[email protected]>
Signed-off-by: Jesús Benito Calzada <[email protected]>
Signed-off-by: Jesús Benito Calzada <[email protected]>
Signed-off-by: Jesús Benito Calzada <[email protected]>
Signed-off-by: Jesús Benito Calzada <[email protected]>
Signed-off-by: Jesús Benito Calzada <[email protected]>
Signed-off-by: Jesús Benito Calzada <[email protected]>
Signed-off-by: Jesús Benito Calzada <[email protected]>
Signed-off-by: Jesús Benito Calzada <[email protected]>
Signed-off-by: Jesús Benito Calzada <[email protected]>
Signed-off-by: Jesús Benito Calzada <[email protected]>
Signed-off-by: Jesús Benito Calzada <[email protected]>
Signed-off-by: Jesús Benito Calzada <[email protected]>
Signed-off-by: Jesús Benito Calzada <[email protected]>
Signed-off-by: Jesús Benito Calzada <[email protected]>
Signed-off-by: Jesús Benito Calzada <[email protected]>
…st sync_to_bitnami Signed-off-by: Jesús Benito Calzada <[email protected]>
Signed-off-by: Jesús Benito Calzada <[email protected]>
Signed-off-by: Jesús Benito Calzada <[email protected]>
…nami Signed-off-by: Jesús Benito Calzada <[email protected]>
Signed-off-by: Jesús Benito Calzada <[email protected]>
✅ Deploy Preview for kubeapps-dev canceled.
|
Signed-off-by: Jesús Benito Calzada <[email protected]>
Signed-off-by: Jesús Benito Calzada <[email protected]>
30 tasks
beni0888
changed the title
Fix sync from bitnami gha
Fix the jobs sync from/to bitnami in the GHA's "kubeapps general" workflow
Oct 20, 2022
Signed-off-by: Jesús Benito Calzada <[email protected]>
Signed-off-by: Jesús Benito Calzada <[email protected]>
beni0888
added
component/ci
Issue related to kubeapps ci system
github_actions
Pull requests that update GitHub Actions code
labels
Oct 20, 2022
castelblanque
approved these changes
Oct 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent. Thanks for the investigation, the fix and the improvements!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cla-not-required
component/ci
Issue related to kubeapps ci system
github_actions
Pull requests that update GitHub Actions code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
The changes in this PR are aimed at fixing the issues with the GHA's jobs
sync_from_bitnami
andsync_to_bitnami
that have been failing so far. The main problem was that the GHA runner wasn't able to connect to the required GitHub repositorieskubeapps-bot/charts
andbitnami/charts
, mainly because in our scripts we were using theHTTPS
protocol for defining the remotes for those repositories, and that made thegit
commands to ask for credentials instead of using the corresponding SSH keys. The reason why this wasn't failing in GHA workflow and not in the CircleCI one, is that for some unknown reason (at least for me, although I suspect it has to do with the use of the checkout step), the CircleCI runner has a specific~/.gitconfig
setup as follows:So it was transparently using
git over ssh
protocol and taking advantage of the configured keys in the runner.Besides that, in this PR I have taken advantage to document some of the functions used by the
bash
scripts that support those jobs and refactor them (mainly renaming variables) to try to better convey the actual intention and responsibility of each script and function (although I cannot be 100% sure I got my goal).Also, during the development/debugging/head-hitting-against-the-wall process, I discovered that we have added some unnecessary/unused SSH keys to the jobs, so I have removed the associated code and, hopefully, some complexity from the workflow.
Finally, while working on this, I detected a bug in the code of the
setup
job in charge of setting the value for thetriggered_from_fork
output variable, so it's been fixed and a previous step has been added to that job, sending to the output the value of thegithub.event
that triggered the workflow, just with debugging purposes.Benefits
sync_from_bitnami
andsync_to_bitnami
from GHA'skubeapps general workflow
work as expected.setup
job's output variabletriggered_from_fork
is now set as expected.Possible drawbacks
Applicable issues
Additional information