Change IMG_MODIFIER suffix for the GHA workflow #5430
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Currently, both GHA and CircleCI workflows (aka. pipelines), are running in parallel and configured to generate the development docker images using the same suffix
-ci
to avoid polluting the canonical images repository. However, this leads us to a situation where both pipelines overlap when it comes to pushing the images to Dockerhub, and cannot make sure which was the pipeline that generated each published image (it will depend on which finishes last).Benefits
We can clearly identify which workflow generated what image and avoid overlap by having the images generated by both repositories publicly available in Dockerhub, under different suffixes.
Possible drawbacks
Nothing, as we're in the development phase of the GHA workflow, it should have any negative consequences in case we break anything on it.
Applicable issues
Additional information