Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change IMG_MODIFIER suffix for the GHA workflow #5430

Merged

Conversation

beni0888
Copy link
Collaborator

@beni0888 beni0888 commented Oct 5, 2022

Description of the change

Currently, both GHA and CircleCI workflows (aka. pipelines), are running in parallel and configured to generate the development docker images using the same suffix -ci to avoid polluting the canonical images repository. However, this leads us to a situation where both pipelines overlap when it comes to pushing the images to Dockerhub, and cannot make sure which was the pipeline that generated each published image (it will depend on which finishes last).

Benefits

We can clearly identify which workflow generated what image and avoid overlap by having the images generated by both repositories publicly available in Dockerhub, under different suffixes.

Possible drawbacks

Nothing, as we're in the development phase of the GHA workflow, it should have any negative consequences in case we break anything on it.

Applicable issues

Additional information

Jesús Benito Calzada added 2 commits October 5, 2022 11:14
Signed-off-by: Jesús Benito Calzada <[email protected]>
Signed-off-by: Jesús Benito Calzada <[email protected]>
@netlify
Copy link

netlify bot commented Oct 5, 2022

Deploy Preview for kubeapps-dev canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit b28178b
🔍 Latest deploy log https://app.netlify.com/sites/kubeapps-dev/deploys/633d4f89a86e4b0009fac442

@beni0888 beni0888 added the component/ci Issue related to kubeapps ci system label Oct 5, 2022
@beni0888 beni0888 added this to the CI & E2E test improvements milestone Oct 5, 2022
@beni0888 beni0888 self-assigned this Oct 5, 2022
Copy link
Contributor

@antgamdia antgamdia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, this way we avoid the overlap between different CI runs. Later on, we can just remove the -gha images from DockerHub manually, as they are just temporary.

@beni0888 beni0888 marked this pull request as ready for review October 5, 2022 10:11
@beni0888 beni0888 merged commit 7260592 into vmware-tanzu:main Oct 5, 2022
@beni0888 beni0888 deleted the gha-pipeline-change-img-modifier branch October 5, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-not-required component/ci Issue related to kubeapps ci system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants