kubeconfig flag removed in the agent #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #578 +/- ##
==========================================
+ Coverage 67.46% 67.81% +0.35%
==========================================
Files 27 27
Lines 2410 2399 -11
==========================================
+ Hits 1626 1627 +1
+ Misses 676 664 -12
Partials 108 108
|
shubham14bajpai
previously approved these changes
Jun 8, 2022
dharmjit
changed the title
anusha94
reviewed
Jun 9, 2022
dharmjit
dismissed stale reviews from sachinkumarsingh092 and shubham14bajpai
via
d7eb6a2
dharmjit
changed the title
shubham14bajpai
approved these changes
Jun 10, 2022
Closed
shivi28
pushed a commit
to shivi28/cluster-api-provider-bringyourownhost
that referenced
this pull request
Jun 13, 2022
* flag --kubeconfig removed * Changes for fetching home dir for containers * Create bootstrap kubeconfig for e2e tests * update installer e2e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR removes the
--kubeconfigflag from the HostAgent to support only the bootstrap kubeconfig flow via--bootstrap-kubeconfigflag. Some RBACs are updated as well.--kubeconfigare updated and will use--bootstrap-kubeconfigflag with valid bootstrap kubeconfig with only permissions to create CSR.~/.byoh/config. Please note that this kubeconfig is the one with admin priveleges.Which issue(s) this PR fixes :
Fixes #582