Bootstrap kubeconfig controller #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anusha94
force-pushed
the
bootstrap-kubeconfig-controller
branch
2 times, most recently
from
613d155 to
0ca71ca
Compare
Codecov Report
@@ Coverage Diff @@
## main #586 +/- ##
==========================================
- Coverage 67.75% 67.41% -0.34%
==========================================
Files 26 27 +1
Lines 2388 2440 +52
==========================================
+ Hits 1618 1645 +27
- Misses 662 679 +17
- Partials 108 116 +8
|
anusha94
force-pushed
the
bootstrap-kubeconfig-controller
branch
3 times, most recently
from
51a6ed4 to
042cc55
Compare
anusha94
commented
Jun 16, 2022
Ankitasw
reviewed
Jun 20, 2022
shamsher31
reviewed
Jun 21, 2022
shamsher31
reviewed
Jun 21, 2022
shamsher31
reviewed
Jun 21, 2022
shamsher31
reviewed
Jun 21, 2022
@Ankitasw Yes! |
shamsher31
reviewed
Jun 21, 2022
anusha94
force-pushed
the
bootstrap-kubeconfig-controller
branch
from
a10bf84 to
a524548
Compare
|
Created a new issue for webhook #605 |
|
LGTM |
Ankitasw
approved these changes
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds a new CRD
BootstrapKubeconfigand corresponding controllers and tests.Whenever a CR of Kind
BootstrapKubeconfigis created, we will generate a bootstrap kubeconfig and add it to theStatus.BootstrapKubeconfigDatafield.This data can be consumed by the user to dump in into a file and pass it on to the agent to be used for the bootstrap-token workflow.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #597