Add version flag to host agent #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raunaksingwi
requested review from
jamiemonserrate,
dharmjit,
shamsher31 and
anusha94
dharmjit
reviewed
Jan 24, 2022
There was a problem hiding this comment.
IMO, we need a consistent organization for HostAgent flags related code. Currently some of the code(help, labels flag) is inside main package and this PR introduces a new package version. How could we make it more cleaner? thoughts @anusha94 @raunaksingwi @huchen2021
Add version flag to the host agent so that the user can know the version being used. The output shows the version of the binary and the time it was built.
Agreed. All flags are all over the place now. @raunaksingwi Mind creating a new issue to address this so that this PR is unblocked? |
anusha94
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add version flag to the host agent so that the user can know the version being used.
The output shows the version of the binary and the time it was built.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #278
Additional information
Used ldflags to embed the version number and time at build time in the binary.
The version number has to be passed as a variable to the Makefile. It will be passed by the GH action while the build is triggered.
When the version is not passed, it takes the default as "dev"