Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --version flag to host agent binary #278

Closed
dharmjit opened this issue Dec 1, 2021 · 4 comments · Fixed by #346
Closed

Add --version flag to host agent binary #278

dharmjit opened this issue Dec 1, 2021 · 4 comments · Fixed by #346
Assignees
Labels
Milestone

Comments

@dharmjit
Copy link
Contributor

dharmjit commented Dec 1, 2021

It will be useful to provide a --version flag in the host-agent binary as we will have multiple agent releases so that the user can know the version being used. The output could consist of information in the below format

$ byoh-hostagent-linux-amd64 --version
Version: v0.1.0_alpha.2
BuildDate: 
...
@raunaksingwi
Copy link
Contributor

I can take this one

@anusha94 anusha94 added this to the v0.1.1 milestone Jan 10, 2022
@anusha94
Copy link
Contributor

/assign @raunaksingwi

@raunaksingwi
Copy link
Contributor

Are we manually going to update the version (in the Makefile) or do we have to derive the version from some other variables like GOOS, GOARCH, etc?

@anusha94
Copy link
Contributor

The build job will be triggered when we push a tag to the repo. See this job -

run: IMG="projects.registry.vmware.com/cluster_api_provider_bringyourownhost/cluster-api-byoh-controller:${{ github.ref_name }}" make build-release-artifacts

You can use the ${{ github.ref_name }} - this is going to be the agent binary version.
Does that answer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants