Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add floppy_content for Ubuntu Server 18.04 LTS #82

Merged
merged 3 commits into from
Oct 19, 2021
Merged

Add floppy_content for Ubuntu Server 18.04 LTS #82

merged 3 commits into from
Oct 19, 2021

Conversation

sestegra
Copy link
Contributor

@sestegra sestegra commented Oct 1, 2021 •
edited
Loading

Summary of Pull Request

Use floppy_content for Ubuntu Server 18.04 LTS

Type of Pull Request

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style / formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is something else.
    Please describe:

Context of the Pull Request*

Requires hashicorp/packer-plugin-vsphere#117

Related to Existing Issues

Issue Number: N/A

Test and Documentation Coverage

  • Tests have been completed (for bug fixes / features).
  • Documentation has been added / updated (for bug fixes / features).

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

@sestegra
Add floppy_content for Ubuntu Server 18.04 LTS
54a1beb 
Signed-off-by: Stéphane Este-Gracias <[email protected]>
@tenthirtyam tenthirtyam self-requested a review October 1, 2021 18:44
@tenthirtyam tenthirtyam self-assigned this Oct 1, 2021
@tenthirtyam
Copy link
Collaborator

Will hold until hashicorp/packer-plugin-vsphere#117 is included in a Packer release.

Ryan

@sestegra
Merge branch 'main' into floppy_content
0740efe 
Signed-off-by: Stéphane Este-Gracias <[email protected]>
@tenthirtyam
Copy link
Collaborator

Looks like it should make its way into the next release of the vSphere plugin! 👍🏻

@tenthirtyam
Copy link
Collaborator

v1.0.2 of the plugin has been released with the awesome contribution by @sestegra. I'll bump the required versions for the plugin, test, and merge tomorrow if all goes well.

Ryan

Update required_plugins for vsphere to >= v1.0.2
2b938b9 
- Updating the `required_plugins` for `vsphere` to `>= v1.0.2` to incorporate support for `floppy_content`.
- Syncing the recent changes for the `ansible` provisioner.
tenthirtyam
tenthirtyam approved these changes Oct 19, 2021
View reviewed changes
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Reviewed
✅ Tested
✅ Approved

@tenthirtyam tenthirtyam merged commit e76accc into vmware-samples:main Oct 19, 2021
@tenthirtyam
Copy link
Collaborator

@sestegra - Congrats again on the hashicorp/packer-plugin-vsphere#117 contribution included in hashicorp/packer-plugin-vsphere/releases/tag/v1.0.2. Many thanks for driving this excellent update to the project. 🚀

Ryan

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tenthirtyam tenthirtyam tenthirtyam approved these changes

Assignees

@tenthirtyam tenthirtyam

Labels
priority/medium Priority Medium sev/minor Minor size/s Small type/enhancement Enhancement type/refactor Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sestegra @tenthirtyam