Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support floppy_content parameter #117

Merged
merged 3 commits into from
Oct 11, 2021
Merged

Conversation

sestegra
Copy link
Contributor

@sestegra sestegra commented Oct 1, 2021

Add similar parameter as http_content and cd_content, but for floppy.

Requires packer-plugin-sdk with following PR hashicorp/packer-plugin-sdk#82
Closes #110

Signed-off-by: Stéphane Este-Gracias <[email protected]>
@sestegra sestegra requested a review from a team as a code owner October 1, 2021 17:15
@sestegra sestegra changed the title Support floppy_content Support floppy_content parameter Oct 1, 2021
@azr
Copy link
Contributor

azr commented Oct 6, 2021

👋🏼 Hello there, thanks for doing this here !
I think this PR should simply need an update of the deps !

@sestegra
Copy link
Contributor Author

sestegra commented Oct 6, 2021

@azr Do you know when a new version of packer-plugin-sdk will be scheduled?

@azr
Copy link
Contributor

azr commented Oct 7, 2021

@sestegra not sure yet. But this should not be blocking, we can still go get @master here in this branch to see if things work.

@azr
Copy link
Contributor

azr commented Oct 8, 2021

👋🏼 It was just released !

Signed-off-by: Stéphane Este-Gracias <[email protected]>
Signed-off-by: Stéphane Este-Gracias <[email protected]>
@sestegra
Copy link
Contributor Author

sestegra commented Oct 8, 2021

@azr Thanks for the update. PR is ready to merge

Copy link
Contributor

@azr azr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks !!!

@azr azr merged commit bbb1db3 into hashicorp:main Oct 11, 2021
powertim pushed a commit to powertim/packer-plugin-vsphere that referenced this pull request Nov 14, 2023
* Support floppy_content
* Update packer-plugin-sdk to v0.2.7

Signed-off-by: Stéphane Este-Gracias <[email protected]>
@hashicorp hashicorp locked and limited conversation to collaborators Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add floppy_content similar to cd_content
2 participants