Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datepicker: min/max validation not updated #816

Closed
ekrismer opened this issue Jul 17, 2023 · 2 comments
Closed

Datepicker: min/max validation not updated #816

ekrismer opened this issue Jul 17, 2023 · 2 comments
Assignees
@venkateshr06
Labels
type:fix

Comments

@ekrismer
Copy link

Describe the bug

The min and max input of the clarity date picker do not react to changes to the provided value.

How to reproduce

See this stackblitz: https://stackblitz.com/edit/clarity-light-theme-clr15-xuikzh?file=src%2Fapp%2Fapp.component.html

Steps to reproduce the behavior:

  1. Update or clear minDate
  2. Update or clear maxDate

Expected behavior

When clearing or updating the min/max dates the input should become valid.

Versions

Clarity version:

@clr/angular 15.1.0
@angular/core 15.0.4
@cds/core 6.4.4

Additional notes

The validation feature was introduced in #360
@dtsanevmw dtsanevmw mentioned this issue Jan 19, 2024
Merged
13 tasks
venkateshr06 added a commit that referenced this issue Jan 21, 2024
@venkateshr06
fix(date-picker): trigger validation on min/max date change (#1138)
497bac5 
## PR Checklist

Please check if your PR fulfills the following requirements:

- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ] If applicable, have a visual design approval

## PR Type

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

- [x] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

## What is the current behavior?

<!-- Please describe the current behavior that you are modifying, or
link to a relevant issue. -->

Issue Number: #816  CDE-1584

## What is the new behavior?

## Does this PR introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this PR contains a breaking change, please describe the impact
and migration path for existing applications below. -->

## Other information

---------

Co-authored-by: Venkatesh Rajendran <[email protected]>
venkateshr06 added a commit to venkateshr06/ng-clarity that referenced this issue Jan 22, 2024
@venkateshr06
fix(date-picker): trigger validation on min/max date change (vmware-c…
b93ce38 
…larity#1138)

## PR Checklist

Please check if your PR fulfills the following requirements:

- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ] If applicable, have a visual design approval

## PR Type

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

- [x] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

## What is the current behavior?

<!-- Please describe the current behavior that you are modifying, or
link to a relevant issue. -->

Issue Number: vmware-clarity#816  CDE-1584

## What is the new behavior?

## Does this PR introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this PR contains a breaking change, please describe the impact
and migration path for existing applications below. -->

## Other information

---------

Co-authored-by: Venkatesh Rajendran <[email protected]>
@venkateshr06 venkateshr06 mentioned this issue Jan 22, 2024
Merged
venkateshr06 added a commit to venkateshr06/ng-clarity that referenced this issue Jan 22, 2024
@venkateshr06
fix(date-picker): trigger validation on min/max date change (vmware-c…
aac8040 
…larity#1138)

## PR Checklist

Please check if your PR fulfills the following requirements:

- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ] If applicable, have a visual design approval

## PR Type

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

- [x] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

## What is the current behavior?

<!-- Please describe the current behavior that you are modifying, or
link to a relevant issue. -->

Issue Number: vmware-clarity#816  CDE-1584

## What is the new behavior?

## Does this PR introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this PR contains a breaking change, please describe the impact
and migration path for existing applications below. -->

## Other information

---------

Co-authored-by: Venkatesh Rajendran <[email protected]>
@venkateshr06 venkateshr06 mentioned this issue Jan 22, 2024
Merged
@dtsanevmw
Copy link
Contributor

Issue is fixed and merged in 15.x, 16.x and 17.x

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 8, 2024

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@venkateshr06 venkateshr06

Labels
type:fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kevinbuhmann @ekrismer @dtsanevmw @venkateshr06