Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datepicker): validate min/max date #360

Merged
merged 1 commit into from
Oct 31, 2022
Merged

Conversation

kevinbuhmann
Copy link
Member

@kevinbuhmann kevinbuhmann commented Oct 25, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • [N/A] If applicable, have a visual design approval

PR Type

Bugfix

What is the current behavior?

The datepicker control does not report errors when the entered date violates a min/max constraint.

Issue Number: VPAT-664

What is the new behavior?

The datepicker control reports error when the entered date violates a min/max constraint. The input will show the error state (red underline and icon), but it is up the application to display an error message.

Does this PR introduce a breaking change?

No.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2022

👋 @kevinbuhmann,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, checkout out a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal #clarity-support Slack channel

Thank you,

🤖 Clarity Release Bot

@kevinbuhmann kevinbuhmann force-pushed the kevin/date-validator branch 5 times, most recently from 8168db3 to ee17f54 Compare October 25, 2022 20:07
@kevinbuhmann kevinbuhmann changed the title fix(datepicker): validate min/max date (report error to control) fix(datepicker): validate min/max date Oct 25, 2022
@kevinbuhmann
Copy link
Member Author

@kevinbuhmann kevinbuhmann merged commit e9adcc3 into main Oct 31, 2022
@kevinbuhmann kevinbuhmann deleted the kevin/date-validator branch October 31, 2022 15:55
@github-actions
Copy link
Contributor

🎉 This PR is included in version 13.9.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants