Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI/Build][LoRA] Temporarily fix long context failure issue #9579

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

jeejeelee
Copy link
Contributor

@jeejeelee jeejeelee commented Oct 22, 2024

#7049 added the parameter disable_async_output_proc with a default value of False, which led to test_long_context raising an IndexError: list index out of range error, see: https://buildkite.com/vllm/ci-aws/builds/7645#01919198-199d-488c-9834-8c48ae675338/193-420. Since then, this test has consistently shown this error, which has hidden errors introduced by other PRs. For example, when setting disable_async_output_proc=True, inference works without errors but generates incorrect results due to the cudagraph issue from #8645 (which has been fixed by #9549).

This PR is a temporary solution to make this test pass correctly, so that issues like #8645 can be exposed earlier in CI.

ping @DarkLight1337 , also cc @megha95 @alexm-neuralmagic

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 22, 2024
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@jeejeelee
Copy link
Contributor Author

Mark: test_long_context.py test passed,see: https://buildkite.com/vllm/ci-aws/builds/10183#0192b31a-7610-4295-b9e8-8c18fb417560

@DarkLight1337 DarkLight1337 merged commit a48e3ec into vllm-project:main Oct 22, 2024
43 checks passed
charlifu pushed a commit to charlifu/vllm that referenced this pull request Oct 23, 2024
@jeejeelee jeejeelee deleted the fix-long-context-lora branch October 23, 2024 16:30
vrdn-23 pushed a commit to vrdn-23/vllm that referenced this pull request Oct 23, 2024
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
MErkinSag pushed a commit to MErkinSag/vllm that referenced this pull request Oct 26, 2024
garg-amit pushed a commit to garg-amit/vllm that referenced this pull request Oct 28, 2024
FerdinandZhong pushed a commit to FerdinandZhong/vllm that referenced this pull request Oct 29, 2024
NickLucche pushed a commit to NickLucche/vllm that referenced this pull request Oct 31, 2024
NickLucche pushed a commit to NickLucche/vllm that referenced this pull request Oct 31, 2024
sumitd2 pushed a commit to sumitd2/vllm that referenced this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants