-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix][Misc]: fix graph capture for decoder #9549
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved the unblock. Meanwhile, I'm not sure how encoder-decoder works in this case. @varun-sundar-rabindranath PTAL. Also cc @sroy745
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My mistake !! Thanks for the fix @yudian0504 🙌
Good catch, this solved a bug I encountered. |
Signed-off-by: charlifu <[email protected]>
Signed-off-by: Vinay Damodaran <[email protected]>
Signed-off-by: Alvant <[email protected]>
Signed-off-by: Amit Garg <[email protected]>
Signed-off-by: qishuai <[email protected]>
This bug fix is so important, we need a release for the new docker image cc @DarkLight1337 |
For now, you can use the Docker image here with the latest commit. |
Signed-off-by: Sumit Dubey <[email protected]>
This PR fixes a bug introduced by #8645.
related issues: #9448 & #9417 & #9409