Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add test case to run examples scripts #3638

Merged
merged 4 commits into from
Mar 28, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .buildkite/test-pipeline.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,18 @@ steps:
- label: Entrypoints Test
command: pytest -v -s entrypoints

- label: Examples Test
working_dir: "/vllm-workspace/examples"
commands:
# install aws cli for llava_example.py
- pip install awscli
- python3 llava_example.py
- python3 llm_engine_example.py
- python3 multilora_inference.py
- python3 offline_inference_distributed.py
- python3 offline_inference_with_prefix.py
- python3 offline_inference.py

- label: Kernels Test %N
command: pytest -v -s kernels --shard-id=$$BUILDKITE_PARALLEL_JOB --num-shards=$$BUILDKITE_PARALLEL_JOB_COUNT
parallelism: 4
Expand Down
4 changes: 2 additions & 2 deletions examples/llava_example.py
Original file line number Diff line number Diff line change
Expand Up @@ -72,13 +72,13 @@ def main(args):
help="image input type")
args = parser.parse_args()
# Download from s3
s3_bucket_path = "s3://air-example-data-2/vllm_opensource_llava/"
s3_bucket_path = "s3://anonymous@air-example-data-2/vllm_opensource_llava/"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
s3_bucket_path = "s3://anonymous@air-example-data-2/vllm_opensource_llava/"
s3_bucket_path = "s3://air-example-data-2/vllm_opensource_llava/"

local_directory = "images"

# Make sure the local directory exists or create it
os.makedirs(local_directory, exist_ok=True)

# Use AWS CLI to sync the directory
# Use AWS CLI to sync the directory, assume anonymous access
subprocess.check_call(
["aws", "s3", "sync", s3_bucket_path, local_directory])
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Todo add --no-sign-request

main(args)
Loading