[CI] Add test case to run examples scripts #3638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simon-mo
commented
Mar 26, 2024
examples/llava_example.py
Outdated
| @@ -72,13 +72,13 @@ def main(args): | |||
| help="image input type") | |||
| args = parser.parse_args() | |||
| # Download from s3 | |||
| s3_bucket_path = "s3://air-example-data-2/vllm_opensource_llava/" | |||
| s3_bucket_path = "s3://anonymous@air-example-data-2/vllm_opensource_llava/" | |||
There was a problem hiding this comment.
Suggested change
| s3_bucket_path = "s3://anonymous@air-example-data-2/vllm_opensource_llava/" | |
| s3_bucket_path = "s3://air-example-data-2/vllm_opensource_llava/" |
examples/llava_example.py
Outdated
| local_directory = "images" | ||
|
|
||
| # Make sure the local directory exists or create it | ||
| os.makedirs(local_directory, exist_ok=True) | ||
|
|
||
| # Use AWS CLI to sync the directory | ||
| # Use AWS CLI to sync the directory, assume anonymous access | ||
| subprocess.check_call( | ||
| ["aws", "s3", "sync", s3_bucket_path, local_directory]) |
There was a problem hiding this comment.
Todo add --no-sign-request
rkooo567
approved these changes
Mar 28, 2024
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Mar 31, 2024
Temirulan
pushed a commit
to Temirulan/vllm-whisper
that referenced
this pull request
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3618