Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[platforms] refactor cpu code #10402

Merged
merged 1 commit into from
Nov 17, 2024
Merged

[platforms] refactor cpu code #10402

merged 1 commit into from
Nov 17, 2024

Conversation

youkaichao
Copy link
Member

part of #9268

@youkaichao
refactor cpu code
7484c32 
Signed-off-by: youkaichao <[email protected]>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@youkaichao youkaichao added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 17, 2024
@DarkLight1337
Copy link
Member

Please check that CPU tests have not soft failed before merging.

@DarkLight1337
Copy link
Member

Might need to merge the fix from #10394 first, but let's see.

@youkaichao
Copy link
Member Author

Please check that CPU tests have not soft failed before merging.

CPU tests passed.

@youkaichao youkaichao merged commit 8d74b5a into vllm-project:main Nov 17, 2024
56 of 63 checks passed
@youkaichao youkaichao deleted the cpu_worker branch November 17, 2024 07:14
@youkaichao youkaichao mentioned this pull request Nov 17, 2024
Open
26 tasks
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Nov 18, 2024
@youkaichao
[platforms] refactor cpu code (vllm-project#10402)
bce660d 
Signed-off-by: youkaichao <[email protected]>
Signed-off-by: Linkun Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xerxes-cn Xerxes-cn Xerxes-cn left review comments

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@youkaichao @DarkLight1337 @Xerxes-cn