Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix][Hardware][CPU] Fix CPU embedding runner with tensor parallel #10394

Merged
merged 1 commit into from
Nov 17, 2024
Merged

[Bugfix][Hardware][CPU] Fix CPU embedding runner with tensor parallel #10394

merged 1 commit into from
Nov 17, 2024
+4 −0

Conversation

Isotr0py
Copy link
Collaborator

@Isotr0py Isotr0py commented Nov 16, 2024 •
edited by github-actions bot
Loading

  • Minor fix for CPU embedding runner to support tensor parallel inference

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@Isotr0py Isotr0py changed the title [Bugfix][Hardware][CPU] Fix CPU embedding runner tensor parallel [Bugfix][Hardware][CPU] Fix CPU embedding runner with tensor parallel Nov 16, 2024
DarkLight1337
DarkLight1337 approved these changes Nov 17, 2024
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) November 17, 2024 06:23
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 17, 2024
@DarkLight1337 DarkLight1337 mentioned this pull request Nov 17, 2024
Merged
@youkaichao youkaichao merged commit cf349c4 into vllm-project:main Nov 17, 2024
60 of 63 checks passed
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Nov 18, 2024
@Isotr0py
[Bugfix][CPU] Fix CPU embedding runner with tensor parallel (vllm-pro…
7539ab8 
…ject#10394)

Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Linkun Chen <[email protected]>
@Isotr0py Isotr0py deleted the fix-cpu-embed-tp branch November 18, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Isotr0py @DarkLight1337 @youkaichao