Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V1] Fix detokenizer ports #10224

Merged
merged 1 commit into from
Nov 11, 2024
Merged

[V1] Fix detokenizer ports #10224

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions vllm/v1/tokenizer/detokenizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,13 @@ def __init__(self, tokenizer_name: str, tokenizer_mode: str,
# For example, it does not terminate properly. We need to improve this.
self.push_port = get_open_port()
self.pull_port = get_open_port()
# NOTE: The push port of the engine process should be the same as the
# pull port of the detokenizer process. Vice versa.
self.detokenizer = DetokenizerProc(tokenizer_name=tokenizer_name,
tokenizer_mode=tokenizer_mode,
trust_remote_code=trust_remote_code,
push_port=self.push_port,
pull_port=self.pull_port)
push_port=self.pull_port,
pull_port=self.push_port)
self.detokenizer.start()

self.zmq_context = zmq.Context()
Expand Down Expand Up @@ -95,8 +97,8 @@ def __init__(
self.tokenizer_name = tokenizer_name
self.tokenizer_mode = tokenizer_mode
self.trust_remote_code = trust_remote_code
# NOTE: The pull_port of the detokenizer should be the same as the
# push_port of the engine. Vice versa.
# NOTE: The pull_port of the detokenizer process should be the same as
# the push_port of the engine process. Vice versa.
self.pull_port = pull_port
self.push_port = push_port

Expand Down