[V1] Fix detokenizer ports #10224
Merged
[V1] Fix detokenizer ports #10224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
Signed-off-by: Woosuk Kwon <[email protected]>
WoosukKwon
force-pushed
the
v1-fix-detoken
branch
from
c1c3ac3
to
2339e01
Compare
|
Ooops - my bad! Thanks for the fix! |
ywang96
approved these changes
Nov 11, 2024
github-actions
bot
added
the
ready
rickyyx
pushed a commit
to rickyyx/vllm
that referenced
this pull request
Nov 13, 2024
Signed-off-by: Woosuk Kwon <[email protected]>
omer-dayan
pushed a commit
to omer-dayan/vllm
that referenced
this pull request
Nov 14, 2024
Signed-off-by: Woosuk Kwon <[email protected]> Signed-off-by: OmerD <[email protected]>
sumitd2
pushed a commit
to sumitd2/vllm
that referenced
this pull request
Nov 14, 2024
Signed-off-by: Woosuk Kwon <[email protected]> Signed-off-by: Sumit Dubey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the port mismatch introduced in #10211