Fix Parallel Execution of CLIP Feature #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…umentException-parallel # Conflicts: # cineast-core/build.gradle
silvanheller
added
waiting-for-approval
Spiess
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves parallel calls to to the CLIP feature (#330), which were caused by initialization problems of CLIP & the tokenizer in heavily parallel scenarios.
It does not prevent parallel model-calls, nor parallel execution of the feature.
As the new Tensorflow version is still on SNAPSHOT, this PR remains on 0.4.1 and is thus ready for review as a slightly updated version of #331 #332
Functionality is fully tested with large-scale evaluation runs for parallel model execution.