Fixing CLIP Parallelism Issues #332
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't understand the intent of this. Why parallelize at all? TensorFlow will make use of as many resources as it can, so presumably, trying to run multiple instances of the same model in parallel on the same hardware will conflict and offer little to no benefit over sequential evaluation. Or am I mistaken in that regard? |
…umentException-parallel # Conflicts: # cineast-core/build.gradle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps the Tensorflow version to 0.5.0-SNAPSHOT and solves parallel calls to to the CLIP model using the apache-commons poling library. This is necessary, testing has shown that removing synchronization leads to the issue described in #330 re-appearing.
This also fixes #330.
This PR is waiting until 0.5.0 is stable.