Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation about grpc-use-static-authentication-callerid flag on vtgate #1454

Merged
merged 1 commit into from
May 9, 2023

Conversation

Phanatic
Copy link
Collaborator

@Phanatic Phanatic commented Apr 26, 2023

Related to vitess PR vitessio/vitess#12961

Depends on: vitessio/vitess#12984

@notfelineit
Copy link
Contributor

Do you want to add the new flag to the flags table as well? https://github.com/vitessio/website/blob/prod/content/en/docs/17.0/reference/programs/vtgate.md

@Phanatic Phanatic force-pushed the immediate-caller-id-precedence branch 2 times, most recently from c592d52 to 20e3c6b Compare April 26, 2023 16:57
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 14.0 and 15.0 changes need to be reverted. This is only relevant for 16.0.2+ (after the original code change is back ported)

@Phanatic Phanatic force-pushed the immediate-caller-id-precedence branch from c23e0cf to e59a499 Compare April 26, 2023 18:38
@Phanatic Phanatic force-pushed the immediate-caller-id-precedence branch from da0db6b to 459edc5 Compare April 26, 2023 18:50
@netlify
Copy link

netlify bot commented Apr 26, 2023

Deploy Preview for vitess ready!

Name Link
🔨 Latest commit 459edc5
🔍 Latest deploy log https://app.netlify.com/sites/vitess/deploys/6449725f2680880008a08b9a
😎 Deploy Preview https://deploy-preview-1454--vitess.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@deepthi deepthi added the do-not-merge PR contains issues or is dependent on another task label Apr 27, 2023
@frouioui frouioui mentioned this pull request Apr 27, 2023
21 tasks
@frouioui frouioui merged commit 6268ed8 into vitessio:prod May 9, 2023
@frouioui frouioui removed the do-not-merge PR contains issues or is dependent on another task label May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants