Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-16.0] vtgate : Disable Automatically setting immediateCallerID to user from static authentication context (#12961) #12984

Merged
merged 6 commits into from
May 9, 2023
Merged

[release-16.0] vtgate : Disable Automatically setting immediateCallerID to user from static authentication context (#12961) #12984

merged 6 commits into from
May 9, 2023

Conversation

vitess-bot[bot]
Copy link
Contributor

@vitess-bot vitess-bot bot commented Apr 26, 2023

Description

This is a backport of #12961.

Phani Raj added 5 commits April 24, 2023 21:12
Disables automatically setting immediateCallerID to User from Static …
33c4a15 
…authentication Context

Signed-off-by: Phani Raj <[email protected]>
Set effectiveCallerID based on these rules
2a989c0 
The client cert common name (if using mTLS)
The effective caller id (if --grpc_use_effective_callerid=true)
The static auth username (if --mysql_use_static_auth_username=true)

Signed-off-by: Phani Raj <[email protected]>
update vtgate help text fixture
fe5b38c 
Signed-off-by: Phani Raj <[email protected]>
Add new test to vtgate_shard_heavy test run
b6f905e 
Signed-off-by: Phani Raj <[email protected]>
Run EffectiveCallerID tests in vtgate_general_heavy
1220a1a 
Signed-off-by: Phani Raj <[email protected]>
@vitess-bot vitess-bot bot added the Backport This is a backport label Apr 26, 2023
@vitess-bot vitess-bot bot requested a review from deepthi as a code owner April 26, 2023 18:12
@vitess-bot vitess-bot bot requested a review from mattlord as a code owner April 26, 2023 18:12
@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says labels Apr 26, 2023
@vitess-bot
Copy link
Contributor Author

vitess-bot bot commented Apr 26, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a test is added or modified, there should be a documentation on top of the test to explain what the expected behavior is what the test does.

If a new flag is being introduced:

  • Is it really necessary to add this flag?
  • Flag names should be clear and intuitive (as far as possible)
  • Help text should be descriptive.
  • Flag names should use dashes (-) as word separators rather than underscores (_).

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow should be required, the maintainer team should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should include a link to an issue that describes the bug.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from VTop, if used there.

@github-actions github-actions bot added this to the v16.0.2 milestone Apr 26, 2023
@deepthi deepthi mentioned this pull request Apr 27, 2023
Merged
@frouioui frouioui removed the NeedsWebsiteDocsUpdate What it says label Apr 27, 2023
frouioui
frouioui approved these changes Apr 27, 2023
View reviewed changes
Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport looks good to me besides the release notes missing (#12961 (comment)) and grpcvtgateconn.Dial being undefined in acls_test.go.

dbussink
dbussink reviewed May 1, 2023
View reviewed changes
go/test/endtoend/vtgate/grpc_server_acls/acls_test.go
clientCreds := &grpcclient.StaticAuthClientCreds{Username: username, Password: password}
creds := grpc.WithPerRPCCredentials(clientCreds)
dialerFunc := grpcvtgateconn.Dial(creds)
dialerName := t.Name()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Phanatic can you fix this?

@GuptaManan100
Copy link
Member

This backport has been pending for a while.

@GuptaManan100 GuptaManan100 mentioned this pull request May 9, 2023
Closed
21 tasks
@GuptaManan100 GuptaManan100 removed the NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work label May 9, 2023
@GuptaManan100
Copy link
Member

I was able to fix up the test.

@GuptaManan100 GuptaManan100 merged commit 808821c into release-16.0 May 9, 2023
@GuptaManan100 GuptaManan100 deleted the backport-12961-to-release-16.0 branch May 9, 2023 08:40
@hmaurer hmaurer mentioned this pull request Mar 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frouioui frouioui frouioui approved these changes

@dbussink dbussink dbussink approved these changes

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100 GuptaManan100 is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@systay systay Awaiting requested review from systay systay is a code owner

Assignees
No one assigned
Labels
Backport This is a backport Component: ACL Type: Bug Type: Regression
Projects
None yet
Milestone
v16.0.2
Development

Successfully merging this pull request may close these issues.
3 participants
@GuptaManan100 @dbussink @frouioui