-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update vreplication design docs #1338
Conversation
…ove file pos doc Signed-off-by: Rohit Nayak <[email protected]>
✅ Deploy Preview for vitess ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
Signed-off-by: Rohit Nayak <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.. few minor comments though
|
||
Also the primary can contain a `query_service_disabled` attribute which is set to false during resharding cutovers. This tells the primary in that shard to reject any queries made to it, as a signal to vtgate in case vtgate routes queries to this primary during the cutover or before it discovers the new serving graph. Here is an example using the same unsharded commerce keyspace and here we specify the `--cell` flag so that cell's topo base path — stored in its `CellInfo` record in the `global` topo — is used: | ||
```bash | ||
$ vtctlclient --server=localhost:15999 TopoCat -- --decode_proto '/cells/zone1/CellInfo' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the use of this first command ?? on local host example it failing as well
|
||
All Vstreams on a tablet share a common engine. Vstreams that are lagging might be seeing a newer (and hence incorrect) version of the schema in case ddls were applied in between. | ||
All Vstreams on a tablet share a common schema engine. Vstreams that are lagging might be seeing a newer (and hence |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't it be 'might not be seeing' ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't it be 'might not be seeing' ?
No, basically the events are older and the schema is newer, hence they are seeing the wrong schema. I have changed the wording of this section to be hopefully clearer.
content/en/docs/16.0/reference/vreplication/internal/tracker.md
Outdated
Show resolved
Hide resolved
content/en/docs/16.0/reference/vreplication/internal/tracker.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Rohit Nayak <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're going to need to update links or add aliases for the old locations. For example:
$ git grep "life-of-a-stream" | grep 16.0
content/en/docs/16.0/reference/vreplication/flags.md:This flag is intended as an option to improve the performance of the [VReplication copy phase](https://vitess.io/docs/design-docs/vreplication/life-of-a-stream/#copy).
content/en/docs/16.0/reference/vreplication/vreplication.md:VReplication works as [a stream or set of streams](../../../../design-docs/vreplication/life-of-a-stream/).
content/en/docs/16.0/reference/vreplication/vreplication.md:* [Copy data](../../../../design-docs/vreplication/life-of-a-stream/#copy)
content/en/docs/16.0/reference/vreplication/vreplication.md:* After copying is finished, it can continuously [replicate](../../../../design-docs/vreplication/life-of-a-stream/#replicate)
For example, look at the a stream or set of streams
link here: https://deploy-preview-1338--vitess.netlify.app/docs/16.0/reference/vreplication/vreplication/
content/en/docs/16.0/reference/vreplication/internal/life-of-a-stream.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
1ec2987
to
2874cf9
Compare
Signed-off-by: Matt Lord <[email protected]>
2874cf9
to
c5dd317
Compare
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
Signed-off-by: Matt Lord <[email protected]>
Review link: https://deploy-preview-1338--vitess.netlify.app/docs/16.0/reference/vreplication/internal/
Signed-off-by: Rohit Nayak [email protected]