Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vreplication design docs #1338

Merged
merged 17 commits into from
Jan 20, 2023
Merged

Update vreplication design docs #1338

merged 17 commits into from
Jan 20, 2023

Conversation

rohit-nayak-ps
Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps commented Jan 7, 2023

  • Reorganized design docs and moved them to `reference/vreplication/internal'
  • Removed pages which already have RFCs and added links to Vitess issues to a new RFC page
  • Minor readability updates to some pages

Review link: https://deploy-preview-1338--vitess.netlify.app/docs/16.0/reference/vreplication/internal/

Signed-off-by: Rohit Nayak [email protected]

@netlify
Copy link

netlify bot commented Jan 7, 2023

Deploy Preview for vitess ready!

Name Link
🔨 Latest commit 257fa94
🔍 Latest deploy log https://app.netlify.com/sites/vitess/deploys/63caee5431912b0008ebac4d
😎 Deploy Preview https://deploy-preview-1338--vitess.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@rohit-nayak-ps rohit-nayak-ps marked this pull request as ready for review January 14, 2023 22:10
Copy link
Collaborator

@rsajwani rsajwani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.. few minor comments though


Also the primary can contain a `query_service_disabled` attribute which is set to false during resharding cutovers. This tells the primary in that shard to reject any queries made to it, as a signal to vtgate in case vtgate routes queries to this primary during the cutover or before it discovers the new serving graph. Here is an example using the same unsharded commerce keyspace and here we specify the `--cell` flag so that cell's topo base path — stored in its `CellInfo` record in the `global` topo — is used:
```bash
$ vtctlclient --server=localhost:15999 TopoCat -- --decode_proto '/cells/zone1/CellInfo'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the use of this first command ?? on local host example it failing as well


All Vstreams on a tablet share a common engine. Vstreams that are lagging might be seeing a newer (and hence incorrect) version of the schema in case ddls were applied in between.
All Vstreams on a tablet share a common schema engine. Vstreams that are lagging might be seeing a newer (and hence
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't it be 'might not be seeing' ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't it be 'might not be seeing' ?

No, basically the events are older and the schema is newer, hence they are seeing the wrong schema. I have changed the wording of this section to be hopefully clearer.

Signed-off-by: Rohit Nayak <[email protected]>
Copy link
Collaborator

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're going to need to update links or add aliases for the old locations. For example:

$ git grep "life-of-a-stream" | grep 16.0
content/en/docs/16.0/reference/vreplication/flags.md:This flag is intended as an option to improve the performance of the [VReplication copy phase](https://vitess.io/docs/design-docs/vreplication/life-of-a-stream/#copy).
content/en/docs/16.0/reference/vreplication/vreplication.md:VReplication works as [a stream or set of streams](../../../../design-docs/vreplication/life-of-a-stream/).
content/en/docs/16.0/reference/vreplication/vreplication.md:* [Copy data](../../../../design-docs/vreplication/life-of-a-stream/#copy)
content/en/docs/16.0/reference/vreplication/vreplication.md:* After copying is finished, it can continuously [replicate](../../../../design-docs/vreplication/life-of-a-stream/#replicate)

For example, look at the a stream or set of streams link here: https://deploy-preview-1338--vitess.netlify.app/docs/16.0/reference/vreplication/vreplication/

@mattlord mattlord self-requested a review January 20, 2023 18:19
Signed-off-by: Matt Lord <[email protected]>
@mattlord mattlord force-pushed the vrep-design-docs branch 2 times, most recently from 1ec2987 to 2874cf9 Compare January 20, 2023 18:33
Signed-off-by: Matt Lord <[email protected]>
@mattlord mattlord merged commit 0a1cb84 into prod Jan 20, 2023
@mattlord mattlord deleted the vrep-design-docs branch January 20, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants