Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs Review] Design Docs #1254

Closed
1 of 6 tasks
Tracked by #1222
rsajwani opened this issue Nov 16, 2022 · 7 comments
Closed
1 of 6 tasks
Tracked by #1222

[Docs Review] Design Docs #1254

rsajwani opened this issue Nov 16, 2022 · 7 comments
Assignees
Labels
documentation enhancement New feature or request

Comments

@rsajwani
Copy link
Collaborator

rsajwani commented Nov 16, 2022

Parent Issue #1222
Vitess github url: https://github.com/vitessio/website

Pages to review:

What to do

  • Make sure the content reflect the current state and facts are up-to-date.
  • Add details if needed either in form of new section on current page or adding new page.
  • Add links/Urls on page are working
  • Deprecate flags should be marked as 'deprecated'
  • Review is done for both V15 and V16

Please note that we are not going to focus of restructuring the website content as part of this project. It is something we will do as a separate project later on.

@rsajwani rsajwani changed the title Design Doc [Docs Review] Design Doc Nov 16, 2022
@rsajwani rsajwani added documentation enhancement New feature or request labels Nov 17, 2022
@deepthi deepthi changed the title [Docs Review] Design Doc [Docs Review] Design Docs Dec 15, 2022
@deepthi
Copy link
Member

deepthi commented Dec 15, 2022

There are separate issues for each section of this page
#1257
#1255
#1256
#1258
etc.
I suggest we close this issue since each of those is assigned to various people.

@deepthi
Copy link
Member

deepthi commented Dec 30, 2022

Based on discussion:

  • VReplication design docs are more than just design at the time of implementation. They describe current behavior. Hence we should move them to Internal or something like that
  • Most other design docs are historical. Current behavior / design is not the same as what is in the docs as things have evolved. So let us replace them with links to the markdown docs in the main repo (vitessio/vitess). See Move Design docs from the website to GitHub repo and add automation #1317

@mattlord mattlord removed their assignment Jan 4, 2023
@rsajwani
Copy link
Collaborator Author

rsajwani commented Jan 5, 2023

We will discuss it with Rohit next week...

@deepthi deepthi mentioned this issue Jan 5, 2023
12 tasks
@deepthi
Copy link
Member

deepthi commented Jan 5, 2023

The query serving team has changed their design docs section to be links to GH issues/RFCs. This makes this page look weird and unbalanced now.
We should rework this so that each section can be clicked through to get to a list of docs, and this page is just a list of sections.
Screenshot 2023-01-05 at 12 45 43 PM

@deepthi
Copy link
Member

deepthi commented Jan 5, 2023

Looks like the way our Hugo template works, if the md files are present in the sub directory, they will show up on this page.
The only way to make them not show up is to remove them from there and keep them somewhere else (like vitessio/vitess/doc) and then link to those in each _index.md.
Even then, we'll have the ugly look of 6 sections with a horizontal line below them and no content unless we rework this page totally.

It should be possible to re-work our Hugo template once we change the VRepl and VTTablet sections to make this better.

@deepthi
Copy link
Member

deepthi commented Jan 11, 2023

A number of the child issues are closed. Let us leave this open until #1258 is complete and we can revisit whether the page layout needs to change.

@mattlord
Copy link
Collaborator

VReplication portion was completed in: #1338

@rohit-nayak-ps rohit-nayak-ps removed their assignment Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants