Fix vreplication panic #5753
Merged
Fix vreplication panic #5753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes vitessio#5752 DBClient was setting the connection to nil after close, which was causing vreplication to panic because it defers a Rollback on all connections. The safer thing is to close the connection, but not set it to nil. There's no test for DBClient, but I've manually verified that this won't panic any more. Signed-off-by: Sugu Sougoumarane <[email protected]>
sougou
force-pushed
the
ss-vrepl-panic
branch
from
fca3afb
to
46bd544
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5752
DBClient was setting the connection to nil after close, which was
causing vreplication to panic because it defers a Rollback on all
connections. The safer thing is to close the connection, but not
set it to nil.
There's no test for DBClient, but I've manually verified that this
won't panic any more.
Signed-off-by: Sugu Sougoumarane [email protected]