VReplication panic on broken connection to external MySQL #5752
Comments
Merged
sougou
added a commit
to planetscale/vitess
that referenced
this issue
Jan 23, 2020
Fixes vitessio#5752 DBClient was setting the connection to nil after close, which was causing vreplication to panic because it defers a Rollback on all connections. The safer thing is to close the connection, but not set it to nil. There's no test for DBClient, but I've manually verified that this won't panic any more. Signed-off-by: Sugu Sougoumarane <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Overview of the Issue
vttablet crashes after many hours of running and a broken connection occurs between the vttablet and the external MySQL db host. It's common to see broken connections every once in a while but the crashes only seem to happen after the tablet has been left running for many hours.
Seems to be related to #5413 but was dismissed due to outdated vitess image.
Reproduction Steps
N/A
Binary version
Operating system and Environment details
OS, Architecture, and any other information you can provide
about the environment.
cat /etc/os-release):uname -sr):uname -m):Log Fragments
panic trace
https://gist.github.com/flopex/05d58c97d7066db0a474fdb97fbfc930
The text was updated successfully, but these errors were encountered: