-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix issue with json unmarshalling of operators with space in them #16905
Conversation
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, TestVExplainKeys
is failing due to missing backticks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16905 +/- ##
==========================================
- Coverage 69.43% 69.42% -0.01%
==========================================
Files 1570 1570
Lines 203798 203812 +14
==========================================
- Hits 141498 141488 -10
- Misses 62300 62324 +24 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Andres Taylor <[email protected]>
Signed-off-by: Andres Taylor <[email protected]>
…tessio#16905) Signed-off-by: Andres Taylor <[email protected]>
Description
In a PR merged earlier today, I accidentally failed to consider binary operators that have spaces in them, such as
not like
andnot in
. This is a fix for that oversight.Related Issue(s)
#16892
Checklist